Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/spdy/spdy_protocol.h

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS fix. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_header_block_test.cc ('k') | net/spdy/spdy_session_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol.h
diff --git a/net/spdy/spdy_protocol.h b/net/spdy/spdy_protocol.h
index 2777ad1e02e9f68fb4e2557d2376cda0495641a8..ff492e293e8a77e110363d7ac9fdda899debdf32 100644
--- a/net/spdy/spdy_protocol.h
+++ b/net/spdy/spdy_protocol.h
@@ -718,9 +718,9 @@ class NET_EXPORT_PRIVATE SpdyFrameWithHeaderBlockIR
~SpdyFrameWithHeaderBlockIR() override;
const SpdyHeaderBlock& header_block() const { return header_block_; }
- void set_header_block(const SpdyHeaderBlock& header_block) {
+ void set_header_block(SpdyHeaderBlock header_block) {
// Deep copy.
- header_block_ = header_block;
+ header_block_ = std::move(header_block);
}
void SetHeader(base::StringPiece name, base::StringPiece value) {
header_block_[name] = value;
« no previous file with comments | « net/spdy/spdy_header_block_test.cc ('k') | net/spdy/spdy_session_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698