Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: net/spdy/spdy_header_block_test.cc

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS fix. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_header_block.cc ('k') | net/spdy/spdy_protocol.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_header_block.h" 5 #include "net/spdy/spdy_header_block.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 string qux("qux"); 89 string qux("qux");
90 EXPECT_EQ("qux2", block1[qux]); 90 EXPECT_EQ("qux2", block1[qux]);
91 EXPECT_EQ("qux2", block1.GetHeader(qux)); 91 EXPECT_EQ("qux2", block1.GetHeader(qux));
92 EXPECT_EQ(Pair("key", "value"), *block1.find("key")); 92 EXPECT_EQ(Pair("key", "value"), *block1.find("key"));
93 93
94 block1.erase("key"); 94 block1.erase("key");
95 EXPECT_EQ(block1.end(), block1.find("key")); 95 EXPECT_EQ(block1.end(), block1.find("key"));
96 EXPECT_EQ("", block1.GetHeader("key")); 96 EXPECT_EQ("", block1.GetHeader("key"));
97 } 97 }
98 98
99 // This test verifies that SpdyHeaderBlock can be copied. 99 // This test verifies that SpdyHeaderBlock can be copied using Clone().
100 TEST(SpdyHeaderBlockTest, CopyBlocks) { 100 TEST(SpdyHeaderBlockTest, CopyBlocks) {
101 SpdyHeaderBlock block1; 101 SpdyHeaderBlock block1;
102 block1["foo"] = string(300, 'x'); 102 block1["foo"] = string(300, 'x');
103 block1["bar"] = "baz"; 103 block1["bar"] = "baz";
104 block1.ReplaceOrAppendHeader("qux", "qux1"); 104 block1.ReplaceOrAppendHeader("qux", "qux1");
105 105
106 SpdyHeaderBlock block2; 106 SpdyHeaderBlock block2 = block1.Clone();
107 block2 = block1; 107 SpdyHeaderBlock block3(block1.Clone());
108
109 SpdyHeaderBlock block3(block1);
110 108
111 EXPECT_EQ(block1, block2); 109 EXPECT_EQ(block1, block2);
112 EXPECT_EQ(block1, block3); 110 EXPECT_EQ(block1, block3);
113 } 111 }
114 112
115 TEST(SpdyHeaderBlockTest, ToNetLogParamAndBackAgain) { 113 TEST(SpdyHeaderBlockTest, ToNetLogParamAndBackAgain) {
116 SpdyHeaderBlock headers; 114 SpdyHeaderBlock headers;
117 headers["A"] = "a"; 115 headers["A"] = "a";
118 headers["B"] = "b"; 116 headers["B"] = "b";
119 117
(...skipping 18 matching lines...) Expand all
138 136
139 EXPECT_EQ(block1, block2); 137 EXPECT_EQ(block1, block2);
140 EXPECT_NE(block1, block3); 138 EXPECT_NE(block1, block3);
141 139
142 block2["baz"] = "qux"; 140 block2["baz"] = "qux";
143 EXPECT_NE(block1, block2); 141 EXPECT_NE(block1, block2);
144 } 142 }
145 143
146 } // namespace test 144 } // namespace test
147 } // namespace net 145 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_header_block.cc ('k') | net/spdy/spdy_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698