Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Unified Diff: net/spdy/bidirectional_stream_spdy_impl_unittest.cc

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS fix. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_utils.h ('k') | net/spdy/buffered_spdy_framer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/bidirectional_stream_spdy_impl_unittest.cc
diff --git a/net/spdy/bidirectional_stream_spdy_impl_unittest.cc b/net/spdy/bidirectional_stream_spdy_impl_unittest.cc
index e0340172187856ee5120be5c814f85bb023d3f24..62572dc3e458d93df3414be43a1e05454dd4c84c 100644
--- a/net/spdy/bidirectional_stream_spdy_impl_unittest.cc
+++ b/net/spdy/bidirectional_stream_spdy_impl_unittest.cc
@@ -63,7 +63,7 @@ class TestDelegateBase : public BidirectionalStreamImpl::Delegate {
void OnHeadersReceived(const SpdyHeaderBlock& response_headers) override {
CHECK(!on_failed_called_);
CHECK(!not_expect_callback_);
- response_headers_ = response_headers;
+ response_headers_ = response_headers.Clone();
if (!do_not_start_read_)
StartOrContinueReading();
}
@@ -87,7 +87,7 @@ class TestDelegateBase : public BidirectionalStreamImpl::Delegate {
void OnTrailersReceived(const SpdyHeaderBlock& trailers) override {
CHECK(!on_failed_called_);
- trailers_ = trailers;
+ trailers_ = trailers.Clone();
if (run_until_completion_)
loop_->Quit();
}
@@ -163,8 +163,8 @@ class TestDelegateBase : public BidirectionalStreamImpl::Delegate {
const std::string& data_received() const { return data_received_; }
int bytes_read() const { return bytes_read_; }
int error() const { return error_; }
- const SpdyHeaderBlock response_headers() const { return response_headers_; }
- const SpdyHeaderBlock trailers() const { return trailers_; }
+ const SpdyHeaderBlock& response_headers() const { return response_headers_; }
+ const SpdyHeaderBlock& trailers() const { return trailers_; }
int on_data_read_count() const { return on_data_read_count_; }
int on_data_sent_count() const { return on_data_sent_count_; }
bool on_failed_called() const { return on_failed_called_; }
« no previous file with comments | « net/quic/test_tools/quic_test_utils.h ('k') | net/spdy/buffered_spdy_framer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698