Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 209383003: Move wm/public into wm target (Closed)

Created:
6 years, 9 months ago by Ben Goodger (Google)
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, viettrungluu+watch_chromium.org, tfarina, ben+aura_chromium.org, jam, dcheng, abarth-chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, jochen+watch_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : , #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : . #

Patch Set 16 : . #

Patch Set 17 : . #

Patch Set 18 : . #

Patch Set 19 : . #

Patch Set 20 : . #

Patch Set 21 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -634 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 1 2 3 4 5 6 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 7 chunks +13 lines, -12 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 2 3 4 5 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 3 4 5 6 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/test/base/view_event_test_base.h View 1 2 3 4 5 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 3 4 5 6 3 chunks +6 lines, -7 lines 0 comments Download
M content/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 4 5 6 7 8 9 10 chunks +10 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/test_renderer_host.h View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -9 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 2 3 4 5 6 4 chunks +5 lines, -6 lines 0 comments Download
M content/shell/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/shell_platform_data_aura.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/shell/browser/shell_views.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 6 chunks +54 lines, -5 lines 0 comments Download
M mojo/examples/launcher/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M mojo/mojo_examples.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/aura.gyp View 3 chunks +2 lines, -26 lines 0 comments Download
D ui/aura/client/default_activation_client.h View 1 chunk +0 lines, -69 lines 0 comments Download
D ui/aura/client/default_activation_client.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +6 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_helper.h View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +6 lines, -5 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 2 4 chunks +3 lines, -6 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -1 line 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +6 lines, -6 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -1 line 0 comments Download
M ui/snapshot/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/snapshot.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +3 lines, -4 lines 0 comments Download
M ui/views/test/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/views_test_base.h View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 3 4 5 6 4 chunks +8 lines, -7 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +4 lines, -3 lines 0 comments Download
M ui/wm/core/base_focus_rules.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/capture_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/compound_event_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/compound_event_filter_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/cursor_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/cursor_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/wm/core/default_activation_client.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/wm/core/default_activation_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/easy_resize_window_targeter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/focus_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/focus_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/focus_rules.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/image_grid.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/image_grid_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/input_method_event_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/input_method_event_filter_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/masked_window_targeter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/native_cursor_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/native_cursor_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/shadow.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/shadow_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/shadow_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +4 lines, -3 lines 0 comments Download
M ui/wm/core/shadow_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/transient_window_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_stacking_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_stacking_client_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/visibility_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/wm/core/visibility_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/window_animations.h View 4 chunks +14 lines, -15 lines 0 comments Download
M ui/wm/core/window_animations.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/window_animations_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/window_modality_controller.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/wm/core/window_util.h View 3 chunks +15 lines, -17 lines 0 comments Download
M ui/wm/core/window_util_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -2 lines 0 comments Download
D ui/wm/core/wm_core_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M ui/wm/core/wm_core_switches.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/wm_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/public/activation_change_observer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/wm/public/activation_client.h View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/wm/public/activation_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/public/activation_delegate.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/wm/public/animation_host.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/wm/public/cursor_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +4 lines, -4 lines 0 comments Download
M ui/wm/public/dispatcher_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/wm/public/drag_drop_client.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/wm/public/drag_drop_delegate.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/wm/public/scoped_tooltip_disabler.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/wm/public/tooltip_client.h View 3 chunks +6 lines, -7 lines 0 comments Download
M ui/wm/public/transient_window_client.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/wm/public/window_move_client.h View 3 chunks +4 lines, -5 lines 0 comments Download
A ui/wm/test/wm_test_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +36 lines, -0 lines 0 comments Download
A ui/wm/test/wm_test_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +30 lines, -0 lines 0 comments Download
M ui/wm/test/wm_test_helper.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +7 lines, -27 lines 0 comments Download
M ui/wm/test/wm_test_helper.cc View 1 2 3 4 5 6 1 chunk +19 lines, -31 lines 0 comments Download
M ui/wm/wm.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 6 chunks +33 lines, -16 lines 0 comments Download
A ui/wm/wm_export.h View 17 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Ben Goodger (Google)
6 years, 9 months ago (2014-03-23 06:12:03 UTC) #1
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 9 months ago (2014-03-23 06:12:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/209383003/1
6 years, 9 months ago (2014-03-23 06:12:16 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-23 06:13:55 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-23 06:13:55 UTC) #5
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 9 months ago (2014-03-24 04:36:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/209383003/20001
6 years, 9 months ago (2014-03-24 04:36:24 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 05:41:10 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=286608
6 years, 9 months ago (2014-03-24 05:41:11 UTC) #9
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 9 months ago (2014-03-24 15:23:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/209383003/20001
6 years, 9 months ago (2014-03-24 15:23:41 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 16:21:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-24 16:21:47 UTC) #13
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 9 months ago (2014-03-25 05:51:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/209383003/80001
6 years, 9 months ago (2014-03-25 05:51:24 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 06:23:34 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-25 06:23:34 UTC) #17
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 9 months ago (2014-03-26 05:39:17 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/209383003/470001
6 years, 9 months ago (2014-03-26 05:39:30 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 06:42:51 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-26 06:42:52 UTC) #21
Ben Goodger (Google)
6 years, 9 months ago (2014-03-26 14:48:18 UTC) #22
Message was sent while issue was closed. 
Committed patchset #16 manually as r259580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698