Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2070283002: Use container::back() and container::pop_back(). (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 5 months ago
CC:
aboxhall+watch_chromium.org, alokp+watch_chromium.org, browser-components-watch_chromium.org, caitkp+watch_chromium.org, cbentzel+watch_chromium.org, cc-bugs_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, davemoore+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, Dirk Pranke, dtseng+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gcasto+watchlist_chromium.org, grt+watch_chromium.org, halliwell+watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, je_julie, kalyank, kinuko+fileapi, lcwu+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-notifications_chromium.org, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, nhiroki, oshima+watch_chromium.org, ozone-reviews_chromium.org, Peter Beverloo, Paweł Hajdan Jr., piman+watch_chromium.org, posciak+watch_chromium.org, rginda+watch_chromium.org, rouslan+autofill_chromium.org, sadrul, sync-reviews_chromium.org, tdresser+watch_chromium.org, tfarina, tzik, vabr+watchlistautofill_chromium.org, vabr+watchlistpasswordmanager_chromium.org, wfh+watch_chromium.org, yuzo+watch_chromium.org, Sergey Ulanov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use container::back() and container::pop_back(). Also convert !container.size() to container.empty(). TBR=alexclarke@chromium.org,eugenebut@chromium.org,reillyg@chromium.org,robertshield@chromium.org,rogerta@chromium.org,scheib@chromium.org,sky@chromium.org,wez@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/96e7f36f687d7d44f6eb89829047f4b3e40a7208 Cr-Commit-Position: refs/heads/master@{#404539}

Patch Set 1 : '' #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -70 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mirror_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/property_tree.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/blacklist/blacklist_interceptions.cc View 4 chunks +16 lines, -17 lines 0 comments Download
M chromecast/media/cma/base/buffering_frame_provider_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_socket_bluez.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/features/base_feature_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_requests.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M google_apis/drive/time_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/program_info_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/config/gpu_control_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/perftests/texture_upload_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/tools/compositor_model_bench/compositor_model_bench.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M headless/public/util/error_reporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/request_tracker_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_video_renderer_3d.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_system_url_request_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/common/fileapi/file_system_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 33 (19 generated)
Lei Zhang
brianderson: Can you review cc/, and the other [a-e]* directories? piman: Can you review gpu/, ...
4 years, 5 months ago (2016-07-08 20:28:04 UTC) #10
piman
lgtm
4 years, 5 months ago (2016-07-08 20:49:01 UTC) #11
alokp
chromecast lgtm
4 years, 5 months ago (2016-07-08 22:10:16 UTC) #13
brianderson
lgtm
4 years, 5 months ago (2016-07-08 22:16:05 UTC) #14
Lei Zhang
TBRing the rest: ash, services/ui: sky@chromium.org chrome_elf: robertshield@chromium.org device: scheib@chromium.org extensions: reillyg@chromium.org google_apis: rogerta@chromium.org headless: ...
4 years, 5 months ago (2016-07-08 22:31:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2070283002/80001
4 years, 5 months ago (2016-07-08 22:32:26 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/33079) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-08 22:35:16 UTC) #22
Eugene But (OOO till 7-30)
ios lgtm
4 years, 5 months ago (2016-07-08 22:36:29 UTC) #23
Reilly Grant (use Gerrit)
device and extensions lgtm
4 years, 5 months ago (2016-07-08 22:42:25 UTC) #24
Wez
remoting/ LGTM
4 years, 5 months ago (2016-07-08 22:45:21 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2070283002/100001
4 years, 5 months ago (2016-07-08 23:04:33 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 5 months ago (2016-07-08 23:55:11 UTC) #30
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/96e7f36f687d7d44f6eb89829047f4b3e40a7208 Cr-Commit-Position: refs/heads/master@{#404539}
4 years, 5 months ago (2016-07-08 23:56:35 UTC) #32
scheib
4 years, 5 months ago (2016-07-11 18:03:44 UTC) #33
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698