device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc - Issue 2070283002: Use container::back() and container::pop_back().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

Issue 2070283002: Use container::back() and container::pop_back(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

diff --git a/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc b/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

index 88922dc505c65c9d78bbd9497a280cefc734bb47..b32befc80083f5f6bb406b81c17debac73535d6f 100644

--- a/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

+++ b/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

@@ -115,7 +115,7 @@ void FakeBluetoothGattDescriptorClient::ReadValue(

uint8_t value_byte = chrc_props->notifying.value() ? 0x01 : 0x00;

const std::vector<uint8_t>& cur_value = properties->value.value();

- if (!cur_value.size() || cur_value[0] != value_byte) {

+ if (cur_value.empty() || cur_value[0] != value_byte) {

std::vector<uint8_t> value = {value_byte, 0x00};

properties->value.ReplaceValue(value);

}