Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: headless/public/util/error_reporter.cc

Issue 2070283002: Use container::back() and container::pop_back(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "headless/public/util/error_reporter.h" 5 #include "headless/public/util/error_reporter.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 10
11 namespace headless { 11 namespace headless {
12 12
13 ErrorReporter::ErrorReporter() {} 13 ErrorReporter::ErrorReporter() {}
14 14
15 ErrorReporter::~ErrorReporter() {} 15 ErrorReporter::~ErrorReporter() {}
16 16
17 void ErrorReporter::Push() { 17 void ErrorReporter::Push() {
18 path_.push_back(nullptr); 18 path_.push_back(nullptr);
19 } 19 }
20 20
21 void ErrorReporter::Pop() { 21 void ErrorReporter::Pop() {
22 path_.pop_back(); 22 path_.pop_back();
23 } 23 }
24 24
25 void ErrorReporter::SetName(const char* name) { 25 void ErrorReporter::SetName(const char* name) {
26 DCHECK(!path_.empty()); 26 DCHECK(!path_.empty());
27 path_[path_.size() - 1] = name; 27 path_.back() = name;
28 } 28 }
29 29
30 void ErrorReporter::AddError(base::StringPiece description) { 30 void ErrorReporter::AddError(base::StringPiece description) {
31 std::stringstream error; 31 std::stringstream error;
32 for (size_t i = 0; i < path_.size(); i++) { 32 for (size_t i = 0; i < path_.size(); i++) {
33 if (!path_[i]) { 33 if (!path_[i]) {
34 DCHECK_EQ(i + 1, path_.size()); 34 DCHECK_EQ(i + 1, path_.size());
35 break; 35 break;
36 } 36 }
37 if (i) 37 if (i)
38 error << '.'; 38 error << '.';
39 error << path_[i]; 39 error << path_[i];
40 } 40 }
41 if (error.tellp()) 41 if (error.tellp())
42 error << ": "; 42 error << ": ";
43 error << description; 43 error << description;
44 errors_.push_back(error.str()); 44 errors_.push_back(error.str());
45 } 45 }
46 46
47 bool ErrorReporter::HasErrors() const { 47 bool ErrorReporter::HasErrors() const {
48 return !errors_.empty(); 48 return !errors_.empty();
49 } 49 }
50 50
51 } // namespace headless 51 } // namespace headless
OLDNEW
« no previous file with comments | « gpu/tools/compositor_model_bench/compositor_model_bench.cc ('k') | ios/web/net/request_tracker_impl.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698