Use container::back() and container::pop_back().

chrome_elf/blacklist/blacklist_interceptions.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Implementation of NtMapViewOfSection intercept for 32 bit builds.
 //
 // TODO(robertshield): Implement the 64 bit intercept.
 
 #include "chrome_elf/blacklist/blacklist_interceptions.h"
 
@@ skipping 73 matching lines @@
     UNICODE_STRING* section_string =
         reinterpret_cast<UNICODE_STRING*>(section_name);
     return base::string16(section_string->Buffer,
                           section_string->Length / sizeof(wchar_t));
   }
 
   return base::string16();
 }
 
 bool IsModuleValidImageSection(HANDLE section,
-                               PVOID *base,
+                               PVOID* base,
                                PLARGE_INTEGER offset,
                                PSIZE_T view_size) {
   DCHECK_NT(g_nt_query_section_func);
 
   if (!section || !base || !view_size || offset)
     return false;
 
   SECTION_BASIC_INFORMATION basic_info;
   SIZE_T bytes_returned;
   NTSTATUS ret = g_nt_query_section_func(section, SectionBasicInformation,
                                          &basic_info, sizeof(basic_info),
                                          &bytes_returned);
 
   if (!NT_SUCCESS(ret) || sizeof(basic_info) != bytes_returned)
     return false;
 
   if (!(basic_info.Attributes & SEC_IMAGE))
     return false;
 
   return true;
 }
 
 base::string16 ExtractLoadedModuleName(const base::string16& module_path) {
-  if (module_path.empty() || module_path[module_path.size() - 1] == L'\\')
+  if (module_path.empty() || module_path.back() == L'\\')
     return base::string16();
 
   size_t sep = module_path.find_last_of(L'\\');
   if (sep == base::string16::npos)
     return module_path;
-  else
-    return module_path.substr(sep+1);
+  return module_path.substr(sep + 1);
 }
 
 // Fills |out_name| with the image name from the given |pe| image and |flags|
 // with additional info about the image.
 void SafeGetImageInfo(const base::win::PEImage& pe,
                       std::string* out_name,
                       uint32_t* flags) {
   out_name->clear();
   out_name->reserve(MAX_PATH);
   *flags = 0;
@@ skipping 35 matching lines @@
 
 bool IsSameAsCurrentProcess(HANDLE process) {
   return  (NtCurrentProcess == process) ||
           (::GetProcessId(process) == ::GetCurrentProcessId());
 }
 
 NTSTATUS BlNtMapViewOfSectionImpl(
     NtMapViewOfSectionFunction orig_MapViewOfSection,
     HANDLE section,
     HANDLE process,
-    PVOID *base,
+    PVOID* base,
     ULONG_PTR zero_bits,
     SIZE_T commit_size,
     PLARGE_INTEGER offset,
     PSIZE_T view_size,
     SECTION_INHERIT inherit,
     ULONG allocation_type,
     ULONG protect) {
   NTSTATUS ret = orig_MapViewOfSection(section, process, base, zero_bits,
                                        commit_size, offset, view_size, inherit,
                                        allocation_type, protect);
@@ skipping 46 matching lines @@
       reinterpret_cast<NtQueryVirtualMemoryFunction>(
           GetNtDllExportByName("NtQueryVirtualMemory"));
   g_nt_unmap_view_of_section_func =
       reinterpret_cast<NtUnmapViewOfSectionFunction>(
           GetNtDllExportByName("NtUnmapViewOfSection"));
 
   return (g_nt_query_section_func && g_nt_query_virtual_memory_func &&
           g_nt_unmap_view_of_section_func);
 }
 
-SANDBOX_INTERCEPT NTSTATUS WINAPI BlNtMapViewOfSection(
-    NtMapViewOfSectionFunction orig_MapViewOfSection,
-    HANDLE section,
-    HANDLE process,
-    PVOID *base,
-    ULONG_PTR zero_bits,
-    SIZE_T commit_size,
-    PLARGE_INTEGER offset,
-    PSIZE_T view_size,
-    SECTION_INHERIT inherit,
-    ULONG allocation_type,
-    ULONG protect) {
+SANDBOX_INTERCEPT NTSTATUS WINAPI
+BlNtMapViewOfSection(NtMapViewOfSectionFunction orig_MapViewOfSection,
+                     HANDLE section,
+                     HANDLE process,
+                     PVOID* base,
+                     ULONG_PTR zero_bits,
+                     SIZE_T commit_size,
+                     PLARGE_INTEGER offset,
+                     PSIZE_T view_size,
+                     SECTION_INHERIT inherit,
+                     ULONG allocation_type,
+                     ULONG protect) {
   NTSTATUS ret = STATUS_UNSUCCESSFUL;
 
   __try {
     ret = BlNtMapViewOfSectionImpl(orig_MapViewOfSection, section, process,
                                    base, zero_bits, commit_size, offset,
                                    view_size, inherit, allocation_type,
                                    protect);
   } __except(GenerateCrashDump(GetExceptionInformation())) {
   }
 
   return ret;
 }
 
 #if defined(_WIN64)
 NTSTATUS WINAPI BlNtMapViewOfSection64(
     HANDLE section, HANDLE process, PVOID *base, ULONG_PTR zero_bits,
     SIZE_T commit_size, PLARGE_INTEGER offset, PSIZE_T view_size,
     SECTION_INHERIT inherit, ULONG allocation_type, ULONG protect) {
   return BlNtMapViewOfSection(g_nt_map_view_of_section_func, section, process,
                               base, zero_bits, commit_size, offset, view_size,
                               inherit, allocation_type, protect);
 }
 #endif
 }  // namespace blacklist