gpu/perftests/texture_upload_perftest.cc - Issue 2070283002: Use container::back() and container::pop_back().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/perftests/texture_upload_perftest.cc

Issue 2070283002: Use container::back() and container::pop_back(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/perftests/texture_upload_perftest.cc

diff --git a/gpu/perftests/texture_upload_perftest.cc b/gpu/perftests/texture_upload_perftest.cc

index 984314307882a7d91afad29989ef60a40cd2e815..abb2217826e8c95276e9977fa9514e147892f53c 100644

--- a/gpu/perftests/texture_upload_perftest.cc

+++ b/gpu/perftests/texture_upload_perftest.cc

@@ -408,7 +408,7 @@ class TextureUploadPerfTest : public testing::Test {

for (int i = 0; i < kUploadPerfWarmupRuns + kUploadPerfTestRuns; ++i) {

GenerateTextureData(size, GLFormatBytePerPixel(format), i + 1, &pixels);

auto run = UploadAndDraw(texture_id, size, pixels, format, subimage);

- if (i < kUploadPerfWarmupRuns || !run.size()) {

+ if (i < kUploadPerfWarmupRuns || run.empty()) {

continue;

}

successful_runs++;