Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc

Issue 2070283002: Use container::back() and container::pop_back(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc
diff --git a/chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc b/chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc
index 9b313c2c3bdb4113e40f9dc133c014805e3cd052..46ca5d02b052acd812ee6df359f6c52af17d8824 100644
--- a/chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc
+++ b/chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc
@@ -114,7 +114,7 @@ void AvStreamerTest::Configure(
frame_specs[k].size = 512;
frame_specs[k].has_decrypt_config = ((k % 3) == 0);
}
- frame_specs[frame_specs.size() - 1].is_eos = true;
+ frame_specs.back().is_eos = true;
std::unique_ptr<FrameGeneratorForTest> frame_generator_provider(
new FrameGeneratorForTest(frame_specs));
@@ -230,7 +230,7 @@ TEST_F(AvStreamerTest, FastProviderSlowConsumer) {
FROM_HERE,
base::Bind(&AvStreamerTest::Start, base::Unretained(this)));
message_loop->Run();
-};
+}
TEST_F(AvStreamerTest, SlowProviderFastConsumer) {
bool provider_delayed_pattern[] = { true };
@@ -251,7 +251,7 @@ TEST_F(AvStreamerTest, SlowProviderFastConsumer) {
FROM_HERE,
base::Bind(&AvStreamerTest::Start, base::Unretained(this)));
message_loop->Run();
-};
+}
TEST_F(AvStreamerTest, SlowFastProducerConsumer) {
// Pattern lengths are prime between each other
@@ -280,7 +280,7 @@ TEST_F(AvStreamerTest, SlowFastProducerConsumer) {
FROM_HERE,
base::Bind(&AvStreamerTest::Start, base::Unretained(this)));
message_loop->Run();
-};
+}
// Test case for when AvStreamerProxy::StopAndFlush is invoked while a previous
// flush is pending. This can happen when pipeline is stopped while a seek/flush

Powered by Google App Engine
This is Rietveld 408576698