Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chromecast/media/cma/base/buffering_frame_provider_unittest.cc

Issue 2070283002: Use container::back() and container::pop_back(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/base/buffering_frame_provider_unittest.cc
diff --git a/chromecast/media/cma/base/buffering_frame_provider_unittest.cc b/chromecast/media/cma/base/buffering_frame_provider_unittest.cc
index 7c0c5ba9d3c347cd1398fec107b4b88a2f560caa..7ac7d4b5fa144f8e83e3ca2543bdbfdb1a90f40c 100644
--- a/chromecast/media/cma/base/buffering_frame_provider_unittest.cc
+++ b/chromecast/media/cma/base/buffering_frame_provider_unittest.cc
@@ -73,7 +73,7 @@ void BufferingFrameProviderTest::Configure(
frame_specs[k].size = 512;
frame_specs[k].has_decrypt_config = ((k % 3) == 0);
}
- frame_specs[frame_specs.size() - 1].is_eos = true;
+ frame_specs.back().is_eos = true;
std::unique_ptr<FrameGeneratorForTest> frame_generator_provider(
new FrameGeneratorForTest(frame_specs));
@@ -131,7 +131,7 @@ TEST_F(BufferingFrameProviderTest, FastProviderSlowConsumer) {
FROM_HERE,
base::Bind(&BufferingFrameProviderTest::Start, base::Unretained(this)));
message_loop->Run();
-};
+}
TEST_F(BufferingFrameProviderTest, SlowProviderFastConsumer) {
bool provider_delayed_pattern[] = { true };
@@ -152,7 +152,7 @@ TEST_F(BufferingFrameProviderTest, SlowProviderFastConsumer) {
FROM_HERE,
base::Bind(&BufferingFrameProviderTest::Start, base::Unretained(this)));
message_loop->Run();
-};
+}
TEST_F(BufferingFrameProviderTest, SlowFastProducerConsumer) {
// Lengths are prime between each other so we can test a lot of combinations.
@@ -180,7 +180,7 @@ TEST_F(BufferingFrameProviderTest, SlowFastProducerConsumer) {
FROM_HERE,
base::Bind(&BufferingFrameProviderTest::Start, base::Unretained(this)));
message_loop->Run();
-};
+}
} // namespace media
} // namespace chromecast
« no previous file with comments | « chrome_elf/blacklist/blacklist_interceptions.cc ('k') | chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698