extensions/common/features/base_feature_provider.cc - Issue 2070283002: Use container::back() and container::pop_back().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/base_feature_provider.cc

Issue 2070283002: Use container::back() and container::pop_back(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/features/base_feature_provider.cc

diff --git a/extensions/common/features/base_feature_provider.cc b/extensions/common/features/base_feature_provider.cc

index 710a82749fa1f46a1abe601bfd150fdf0f1f9f9b..40065ff01fece213028bf1cc832ba13efb9bc8b4 100644

--- a/extensions/common/features/base_feature_provider.cc

+++ b/extensions/common/features/base_feature_provider.cc

@@ -180,7 +180,7 @@ std::vector<Feature*> BaseFeatureProvider::GetChildren(const Feature& parent)

const FeatureMap::const_iterator first_child = features_.lower_bound(prefix);

// All children have names before (parent.name() + ('.'+1)).

- ++prefix[prefix.size() - 1];

+ ++prefix.back();

const FeatureMap::const_iterator after_children =

features_.lower_bound(prefix);