Use container::back() and container::pop_back().

chromecast/media/cma/base/buffering_frame_provider_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/media/cma/base/buffering_frame_provider.h"
 
 #include <stddef.h>
 
 #include <list>
 #include <memory>
@@ skipping 55 matching lines @@
   DCHECK_GE(frame_count, 1u);
 
   // Frame generation on the producer and consumer side.
   std::vector<FrameGeneratorForTest::FrameSpec> frame_specs(frame_count);
   for (size_t k = 0; k < frame_specs.size() - 1; k++) {
     frame_specs[k].has_config = (k == 0);
     frame_specs[k].timestamp = base::TimeDelta::FromMilliseconds(40) * k;
     frame_specs[k].size = 512;
     frame_specs[k].has_decrypt_config = ((k % 3) == 0);
   }
-  frame_specs[frame_specs.size() - 1].is_eos = true;
+  frame_specs.back().is_eos = true;
 
   std::unique_ptr<FrameGeneratorForTest> frame_generator_provider(
       new FrameGeneratorForTest(frame_specs));
   std::unique_ptr<FrameGeneratorForTest> frame_generator_consumer(
       new FrameGeneratorForTest(frame_specs));
 
   std::unique_ptr<MockFrameProvider> frame_provider(new MockFrameProvider());
   frame_provider->Configure(provider_delayed_pattern,
                             std::move(frame_generator_provider));
 
@@ skipping 37 matching lines @@
           provider_delayed_pattern + arraysize(provider_delayed_pattern)),
       std::vector<bool>(
           consumer_delayed_pattern,
           consumer_delayed_pattern + arraysize(consumer_delayed_pattern)));
 
   std::unique_ptr<base::MessageLoop> message_loop(new base::MessageLoop());
   message_loop->PostTask(
       FROM_HERE,
       base::Bind(&BufferingFrameProviderTest::Start, base::Unretained(this)));
   message_loop->Run();
-};
+}
 
 TEST_F(BufferingFrameProviderTest, SlowProviderFastConsumer) {
   bool provider_delayed_pattern[] = { true };
   bool consumer_delayed_pattern[] = { false };
 
   const size_t frame_count = 100u;
   Configure(
       frame_count,
       std::vector<bool>(
           provider_delayed_pattern,
           provider_delayed_pattern + arraysize(provider_delayed_pattern)),
       std::vector<bool>(
           consumer_delayed_pattern,
           consumer_delayed_pattern + arraysize(consumer_delayed_pattern)));
 
   std::unique_ptr<base::MessageLoop> message_loop(new base::MessageLoop());
   message_loop->PostTask(
       FROM_HERE,
       base::Bind(&BufferingFrameProviderTest::Start, base::Unretained(this)));
   message_loop->Run();
-};
+}
 
 TEST_F(BufferingFrameProviderTest, SlowFastProducerConsumer) {
   // Lengths are prime between each other so we can test a lot of combinations.
   bool provider_delayed_pattern[] = {
     true, true, true, true, true,
     false, false, false, false
   };
   bool consumer_delayed_pattern[] = {
     true, true, true, true, true, true, true,
     false, false, false, false, false, false, false
   };
 
   const size_t frame_count = 100u;
   Configure(
       frame_count,
       std::vector<bool>(
           provider_delayed_pattern,
           provider_delayed_pattern + arraysize(provider_delayed_pattern)),
       std::vector<bool>(
           consumer_delayed_pattern,
           consumer_delayed_pattern + arraysize(consumer_delayed_pattern)));
 
   std::unique_ptr<base::MessageLoop> message_loop(new base::MessageLoop());
   message_loop->PostTask(
       FROM_HERE,
       base::Bind(&BufferingFrameProviderTest::Start, base::Unretained(this)));
   message_loop->Run();
-};
+}
 
 }  // namespace media
 }  // namespace chromecast