Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue* (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 5 months ago
Reviewers:
haraken, Timothy Loh
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, krit, Eric Willigers, f(malita), fs, gyuyoung2, Justin Novosad, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_remove_const_cast_in_interpolation_type
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CSSPropertyParser::parseSingleValue return a const CSSValue* Make CSSPropertyParser::parseSingleValue return a const CSSValue* instead of a regular CSSValue*. This is an entirely mechanical change that is more semantically correct and safe. R=timloh@chromium.org BUG=526586 Committed: https://crrev.com/d661eb39401a0ff9238c5d97d555c1f78f431edf Cr-Commit-Position: refs/heads/master@{#405961}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -48 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSMatrix.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp View 17 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesCalcParserTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLength.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (12 generated)
sashab
4 years, 6 months ago (2016-06-06 02:03:06 UTC) #1
Timothy Loh
On 2016/06/06 02:03:06, sashab wrote: lgtm
4 years, 6 months ago (2016-06-06 03:10:24 UTC) #2
haraken
modules/ LGTM
4 years, 6 months ago (2016-06-06 03:36:28 UTC) #3
sashab
I added a const_cast<> in CSSUnsupportedStyleValue so I could make this return const in a ...
4 years, 5 months ago (2016-07-18 01:45:19 UTC) #11
haraken
LGTM
4 years, 5 months ago (2016-07-18 01:52:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2038363002/100001
4 years, 5 months ago (2016-07-18 02:53:57 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-18 08:04:50 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 08:04:54 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 08:05:10 UTC) #21
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d661eb39401a0ff9238c5d97d555c1f78f431edf
Cr-Commit-Position: refs/heads/master@{#405961}

Powered by Google App Engine
This is Rietveld 408576698