Make CSSValuePair store const CSSValues

Make CSSValuePair store const CSSValues

Make CSSValuePair store const CSSValues, which involves making the
constructor take and getter methods return const CSSValue*s. This is an
entirely mechanical change that is more semantically correct and safe,
and is pre-work for making CSSStyleValue::toCSSValue() return a const
CSSValue.

BUG=526586
Committed: https://crrev.com/d479da5969016b6343a6515a827a22abb598862d
Cr-Commit-Position: refs/heads/master@{#406459}

[sashab, 2016-07-18 01:36:11]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 01:36:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-07-18 01:39:17]

sashab@chromium.org changed reviewers:
+ nainar@chromium.org

[nainar, 2016-07-18 01:47:00]

LGTM 

Thanks!

https://codereview.chromium.org/2158723002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right):

https://codereview.chromium.org/2158723002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSGradientValue.cpp:492: const CSSValue*
localValue = value;
As per IRL conversation we can just modify value as we were doing before. There
shouldn't be any need to add a new local variable. 

But good to go other than that!

[sashab, 2016-07-18 01:53:12]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 01:53:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 03:26:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 03:26:12]

Dry run: This issue passed the CQ dry run.

[sashab, 2016-07-18 08:41:42]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-07-18 08:41:43]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org
Link to the patchset: https://codereview.chromium.org/2158723002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-07-18 08:41:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 08:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 08:48:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sashab, 2016-07-19 03:33:27]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org

[sashab, 2016-07-19 03:33:28]

Oops sorry haraken ptal :)

[haraken, 2016-07-19 19:54:54]

LGTM

[sashab, 2016-07-20 00:49:17]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-07-20 00:49:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 02:07:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 02:08:10]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 02:10:03]

Description was changed from

==========
Make CSSValuePair store const CSSValues

Make CSSValuePair store const CSSValues, which involves making the
constructor take and getter methods return const CSSValue*s. This is an
entirely mechanical change that is more semantically correct and safe,
and is pre-work for making CSSStyleValue::toCSSValue() return a const
CSSValue.

BUG=526586
==========

to

==========
Make CSSValuePair store const CSSValues

Make CSSValuePair store const CSSValues, which involves making the
constructor take and getter methods return const CSSValue*s. This is an
entirely mechanical change that is more semantically correct and safe,
and is pre-work for making CSSStyleValue::toCSSValue() return a const
CSSValue.

BUG=526586

Committed: https://crrev.com/d479da5969016b6343a6515a827a22abb598862d
Cr-Commit-Position: refs/heads/master@{#406459}
==========

[commit-bot: I haz the power, 2016-07-20 02:10:04]

Patchset 2 (id:??) landed as
https://crrev.com/d479da5969016b6343a6515a827a22abb598862d
Cr-Commit-Position: refs/heads/master@{#406459}