third_party/WebKit/Source/core/svg/SVGLength.cpp - Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.cpp

Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_const_cast_in_interpolation_type

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGLength.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLength.cpp b/third_party/WebKit/Source/core/svg/SVGLength.cpp

index eb915deaae0bfbcfba087d24b208e0c90dc2c5fa..b3c29143acc73b1f878c105add5ef1a1f7b1e6e6 100644

--- a/third_party/WebKit/Source/core/svg/SVGLength.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLength.cpp

@@ -134,11 +134,11 @@ SVGParsingError SVGLength::setValueAsString(const String& string)

}

CSSParserContext svgParserContext(SVGAttributeMode, nullptr);

- CSSValue* parsed = CSSParser::parseSingleValue(CSSPropertyX, string, svgParserContext);

+ const CSSValue* parsed = CSSParser::parseSingleValue(CSSPropertyX, string, svgParserContext);

if (!parsed || !parsed->isPrimitiveValue())

return SVGParseStatus::ExpectedLength;

- CSSPrimitiveValue* newValue = toCSSPrimitiveValue(parsed);

+ const CSSPrimitiveValue* newValue = toCSSPrimitiveValue(parsed);

// TODO(fs): Enable calc for SVG lengths

if (newValue->isCalculated() || !isSupportedCSSUnitType(newValue->typeWithCalcResolved()))

return SVGParseStatus::ExpectedLength;