Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2035373002: Made StylePropertySet::getPropertyCSSValue return a const CSSValue* (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, krit, f(malita), fs, gyuyoung2, Justin Novosad, kenneth.christiansen, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@_fix_cssparser_font_face_descriptor_to_return_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made StylePropertySet::getPropertyCSSValue return a const CSSValue* Made StylePropertySet::getPropertyCSSValue return a const CSSValue*, which is more semantically correct and safe. This also forces callers to make copies of any CSSValues they want to edit before saving them back to the style, making it clearer and more explicit when changes to the style are made. BUG=526586 Committed: https://crrev.com/760f84665f2c58ab1dc7e435260e1573048c16ac Cr-Commit-Position: refs/heads/master@{#405966}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M third_party/WebKit/Source/core/css/FontFace.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
sashab
4 years, 6 months ago (2016-06-09 04:35:08 UTC) #2
Timothy Loh
On 2016/06/09 04:35:08, sashab wrote: lgtm
4 years, 6 months ago (2016-06-09 06:35:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2035373002/60001
4 years, 5 months ago (2016-07-18 08:41:55 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-18 08:45:48 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 08:47:08 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/760f84665f2c58ab1dc7e435260e1573048c16ac
Cr-Commit-Position: refs/heads/master@{#405966}

Powered by Google App Engine
This is Rietveld 408576698