third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp - Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue*

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp

Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_const_cast_in_interpolation_type

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/parser/SizesCalcParserTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp

index 618c5bbb6e61dff2148a46a5e373d75b7bffbe22..d93da360b3e82387b0dcea8cdd5eaa5cfa0e50c3 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp

@@ -10,7 +10,7 @@

namespace blink {

-static int computeNumberOfTracks(CSSValueList* valueList)

+static int computeNumberOfTracks(const CSSValueList* valueList)

{

int numberOfTracks = 0;

for (auto& value : *valueList) {

@@ -23,7 +23,7 @@ static int computeNumberOfTracks(CSSValueList* valueList)

TEST(CSSPropertyParserTest, GridTrackLimit1)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(999999, 20px)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(999999, 20px)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 999999);

@@ -31,7 +31,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit1)

TEST(CSSPropertyParserTest, GridTrackLimit2)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(999999, 20px)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(999999, 20px)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 999999);

@@ -39,7 +39,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit2)

TEST(CSSPropertyParserTest, GridTrackLimit3)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(1000000, 10%)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(1000000, 10%)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 1000000);

@@ -47,7 +47,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit3)

TEST(CSSPropertyParserTest, GridTrackLimit4)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(1000000, 10%)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(1000000, 10%)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 1000000);

@@ -55,7 +55,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit4)

TEST(CSSPropertyParserTest, GridTrackLimit5)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(1000000, [first] min-content [last])");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(1000000, [first] min-content [last])");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 1000000);

@@ -63,7 +63,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit5)

TEST(CSSPropertyParserTest, GridTrackLimit6)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(1000000, [first] min-content [last])");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(1000000, [first] min-content [last])");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 1000000);

@@ -71,7 +71,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit6)

TEST(CSSPropertyParserTest, GridTrackLimit7)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(1000001, auto)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(1000001, auto)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 1000000);

@@ -79,7 +79,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit7)

TEST(CSSPropertyParserTest, GridTrackLimit8)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(1000001, auto)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(1000001, auto)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 1000000);

@@ -87,7 +87,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit8)

TEST(CSSPropertyParserTest, GridTrackLimit9)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(400000, 2em minmax(10px, max-content) 0.5fr)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(400000, 2em minmax(10px, max-content) 0.5fr)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 999999);

@@ -95,7 +95,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit9)

TEST(CSSPropertyParserTest, GridTrackLimit10)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(400000, 2em minmax(10px, max-content) 0.5fr)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(400000, 2em minmax(10px, max-content) 0.5fr)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 999999);

@@ -103,7 +103,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit10)

TEST(CSSPropertyParserTest, GridTrackLimit11)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(600000, [first] 3vh 10% 2fr [nav] 10px auto 1fr 6em [last])");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(600000, [first] 3vh 10% 2fr [nav] 10px auto 1fr 6em [last])");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 999999);

@@ -111,7 +111,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit11)

TEST(CSSPropertyParserTest, GridTrackLimit12)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(600000, [first] 3vh 10% 2fr [nav] 10px auto 1fr 6em [last])");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(600000, [first] 3vh 10% 2fr [nav] 10px auto 1fr 6em [last])");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 999999);

@@ -119,7 +119,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit12)

TEST(CSSPropertyParserTest, GridTrackLimit13)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(100000000000000000000, 10% 1fr)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(100000000000000000000, 10% 1fr)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 1000000);

@@ -127,7 +127,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit13)

TEST(CSSPropertyParserTest, GridTrackLimit14)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(100000000000000000000, 10% 1fr)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(100000000000000000000, 10% 1fr)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 1000000);

@@ -135,7 +135,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit14)

TEST(CSSPropertyParserTest, GridTrackLimit15)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(100000000000000000000, 10% 5em 1fr auto auto 15px min-content)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateColumns, "repeat(100000000000000000000, 10% 5em 1fr auto auto 15px min-content)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 999999);

@@ -143,7 +143,7 @@ TEST(CSSPropertyParserTest, GridTrackLimit15)

TEST(CSSPropertyParserTest, GridTrackLimit16)

{

- CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(100000000000000000000, 10% 5em 1fr auto auto 15px min-content)");

+ const CSSValue* value = CSSParser::parseSingleValue(CSSPropertyGridTemplateRows, "repeat(100000000000000000000, 10% 5em 1fr auto auto 15px min-content)");

ASSERT_TRUE(value);

ASSERT_TRUE(value->isValueList());

EXPECT_EQ(computeNumberOfTracks(toCSSValueList(value)), 999999);