third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_const_cast_in_interpolation_type

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParser.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index ecd2bcbe6ccc31d7c3e18f82e90c822a3506e36c..d7e8419134371f27c8297db7ebac0d14df60aafb 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -45,7 +45,7 @@ public:

HeapVector<CSSProperty, 256>&, StyleRule::RuleType);

// Parses a non-shorthand CSS property

- static CSSValue* parseSingleValue(CSSPropertyID, const CSSParserTokenRange&, const CSSParserContext&);

+ static const CSSValue* parseSingleValue(CSSPropertyID, const CSSParserTokenRange&, const CSSParserContext&);

private:

CSSPropertyParser(const CSSParserTokenRange&, const CSSParserContext&,

@@ -54,7 +54,7 @@ private:

// TODO(timloh): Rename once the CSSParserValue-based parseValue is removed

bool parseValueStart(CSSPropertyID unresolvedProperty, bool important);

bool consumeCSSWideKeyword(CSSPropertyID unresolvedProperty, bool important);

- CSSValue* parseSingleValue(CSSPropertyID, CSSPropertyID = CSSPropertyInvalid);

+ const CSSValue* parseSingleValue(CSSPropertyID, CSSPropertyID = CSSPropertyInvalid);

bool inQuirksMode() const { return isQuirksModeBehavior(m_context.mode()); }