third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp - Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_const_cast_in_interpolation_type

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp b/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

index e2457d30d4da033797c11248662d8568e603d640..5ca9cb88a501d7007c61ef3d7412010dcba5b108 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

@@ -17,7 +17,8 @@ CSSValue* CSSUnsupportedStyleValue::toCSSValue() const

CSSValue* CSSUnsupportedStyleValue::toCSSValueWithProperty(CSSPropertyID propertyID) const

{

- return CSSParser::parseSingleValue(propertyID, m_cssText, strictCSSParserContext());

+ // TODO(sashab): Make CSSStyleValue return const CSSValue*s and remove this cast.

+ return const_cast<CSSValue*>(CSSParser::parseSingleValue(propertyID, m_cssText, strictCSSParserContext()));

}

} // namespace blink