third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp - Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_const_cast_in_interpolation_type

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h ('k') | third_party/WebKit/Source/core/svg/SVGLength.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

index e1d8555b895205edfaf0678e0639ff30f7268a58..8612e67fbbb8ac8b60443f13cd5209e9bcd0d40c 100644

--- a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

@@ -130,7 +130,7 @@ bool CSSVariableResolver::resolveTokenRange(CSSParserTokenRange range,

return success;

}

-CSSValue* CSSVariableResolver::resolveVariableReferences(StyleVariableData* styleVariableData, CSSPropertyID id, const CSSVariableReferenceValue& value)

+const CSSValue* CSSVariableResolver::resolveVariableReferences(StyleVariableData* styleVariableData, CSSPropertyID id, const CSSVariableReferenceValue& value)

{

ASSERT(!isShorthandProperty(id));

@@ -138,7 +138,7 @@ CSSValue* CSSVariableResolver::resolveVariableReferences(StyleVariableData* styl

Vector<CSSParserToken> tokens;

if (!resolver.resolveTokenRange(value.variableDataValue()->tokens(), tokens))

return CSSUnsetValue::create();

- CSSValue* result = CSSPropertyParser::parseSingleValue(id, tokens, strictCSSParserContext());

+ const CSSValue* result = CSSPropertyParser::parseSingleValue(id, tokens, strictCSSParserContext());

if (!result)

return CSSUnsetValue::create();

return result;

@@ -153,7 +153,7 @@ const CSSValue* CSSVariableResolver::resolveVariableReferences(StyleResolverStat

if (resolver.resolveTokenRange(value.variableDataValue()->tokens(), tokens)) {

CSSParserContext context(HTMLStandardMode, nullptr);

- CSSValue* value = CSSPropertyParser::parseSingleValue(id, CSSParserTokenRange(tokens), context);

+ const CSSValue* value = CSSPropertyParser::parseSingleValue(id, CSSParserTokenRange(tokens), context);

if (value)

return value;

}