third_party/WebKit/Source/core/css/parser/CSSParser.cpp - Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParser.cpp

Issue 2038363002: Make CSSPropertyParser::parseSingleValue return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_const_cast_in_interpolation_type

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParser.h ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSParser.cpp

index 0e1454a6b25ff1fd54d3c50da3b508d8d3aad6ab..5af2a021a8c93b75007cce704b40115bd3e65191 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParser.cpp

@@ -100,7 +100,7 @@ bool CSSParser::parseValue(MutableStylePropertySet* declaration, CSSPropertyID u

return CSSParserImpl::parseValue(declaration, unresolvedProperty, string, important, context);

}

-CSSValue* CSSParser::parseSingleValue(CSSPropertyID propertyID, const String& string, const CSSParserContext& context)

+const CSSValue* CSSParser::parseSingleValue(CSSPropertyID propertyID, const String& string, const CSSParserContext& context)

{

if (string.isEmpty())

return nullptr;

@@ -146,7 +146,7 @@ bool CSSParser::parseColor(Color& color, const String& string, bool strict)

return true;

}

- CSSValue* value = CSSParserFastPaths::parseColor(string, strict ? HTMLStandardMode : HTMLQuirksMode);

+ const CSSValue* value = CSSParserFastPaths::parseColor(string, strict ? HTMLStandardMode : HTMLQuirksMode);

// TODO(timloh): Why is this always strict mode?

if (!value)

value = parseSingleValue(CSSPropertyColor, string, strictCSSParserContext());