Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
fdoray, etienneb
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, mcasas+watch+vc_chromium.org, kinuko+cache_chromium.org, Michael van Ouwerkerk, browser-components-watch_chromium.org, gavinp+memory_chromium.org, yzshen+watch_chromium.org, nyquist+watch-blimp_chromium.org, darin-cc_chromium.org, rginda+watch_chromium.org, fdoray+watch_chromium.org, jkarlin+watch_chromium.org, tracing+reviews_chromium.org, isheriff+watch_chromium.org, ben+mojo_chromium.org, shaktisahu+watch-blimp_chromium.org, miu+watch_chromium.org, timvolodine, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, gavinp+disk_chromium.org, imcheng+watch_chromium.org, robliao+watch_chromium.org, tzik, jam, abarth-chromium, posciak+watch_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, gab+watch_chromium.org, sync-reviews_chromium.org, lethalantidote+watch-blimp_chromium.org, kinuko+fileapi, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, vabr+watchlistautofill_chromium.org, michaeln, nasko+codewatch_chromium.org, creis+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, jasonroberts+watch_google.com, devtools-reviews_chromium.org, chromoting-reviews_chromium.org, nhiroki, rlp+watch_chromium.org, jln+watch_chromium.org, media-router+watch_chromium.org, rickyz+watch_chromium.org, rouslan+spell_chromium.org, asvitkine+watch_chromium.org, estade+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, jsbell+idb_chromium.org, darin (slow to review), khushalsagar+watch-blimp_chromium.org, mkwst+watchlist-passwords_chromium.org, rjkroege, Dirk Pranke, feature-media-reviews_chromium.org, anandc+watch-blimp_chromium.org, Dai Mikurube (NOT FULLTIME), sriramsr+watch-blimp_chromium.org, riju_, wfh+watch_chromium.org, mlamouri+watch-sensors_chromium.org, avayvod+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, Aaron Boodman, mmenke, cmumford, tfarina, mkwst+moarreviews-renderer_chromium.org, kmarshall+watch-blimp_chromium.org, cc-bugs_chromium.org, dtrainor+watch-blimp_chromium.org, scheduler-bugs_chromium.org, samuong+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor BUG=612843 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Patch Set 2 : +fixes only made after a full compile of chrome (i.e. on files with compile errors without generate… #

Patch Set 3 : fix presubmits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1032 lines, -494 lines) Patch
M base/allocator/allocator_shim_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/files/file_path_watcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/memory/weak_ptr_unittest.cc View 7 chunks +14 lines, -7 lines 0 comments Download
M base/message_loop/message_loop_task_runner_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/message_loop/message_pump_default.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_pump_libevent_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/posix/unix_domain_socket_linux_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/profiler/stack_sampling_profiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/profiler/stack_sampling_profiler_unittest.cc View 7 chunks +51 lines, -31 lines 0 comments Download
M base/synchronization/waitable_event_unittest.cc View 6 chunks +18 lines, -8 lines 0 comments Download
M base/synchronization/waitable_event_watcher_unittest.cc View 5 chunks +11 lines, -5 lines 0 comments Download
M base/task_scheduler/priority_queue_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/task_scheduler/scheduler_lock_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M base/task_scheduler/scheduler_service_thread_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M base/task_scheduler/scheduler_thread_pool_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M base/task_scheduler/scheduler_thread_pool_impl_unittest.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M base/task_scheduler/scheduler_worker_thread.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/task_scheduler/scheduler_worker_thread_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/task_scheduler/task_tracker_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/test/test_io_thread.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/test/thread_test_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/test/trace_event_analyzer_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M base/threading/platform_thread_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M base/threading/sequenced_task_runner_handle_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/threading/simple_thread.cc View 2 chunks +17 lines, -8 lines 0 comments Download
M base/threading/simple_thread_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M base/threading/thread.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M base/threading/thread_local_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/threading/thread_perftest.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M base/threading/thread_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/threading/worker_pool_posix_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/threading/worker_pool_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_unittest.cc View 10 chunks +35 lines, -15 lines 0 comments Download
M base/trace_event/trace_sampling_thread.cc View 1 chunk +3 lines, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_input_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 1 2 3 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_browsertest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/process_singleton_posix_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/extension_settings_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_directory_sync_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 5 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/ui/crypto_module_delegate_nss.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/service_process_util_posix.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/service/service_ipc_server_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/service_process.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/adb_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/chromedriver/net/net_util.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/chromedriver/net/net_util_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/net/port_server_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/chromedriver/net/test_http_server.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/test/media_router/media_router_base_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service_autofill_unittest.cc View 1 5 chunks +14 lines, -6 lines 0 comments Download
M components/font_service/public/cpp/font_service_thread.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_mojo_proxy.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M components/mus/gles2/gpu_state.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/prefs/pref_member_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M components/storage_monitor/media_storage_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/storage_monitor/test_storage_monitor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_driver/glue/sync_backend_registrar_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sync_driver/glue/ui_model_worker_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/sync_driver/non_ui_data_type_controller_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M components/sync_driver/shared_change_processor_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_request_handler_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_response_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_update_job_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_url_request_job_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/browser_shutdown_profile_dumper.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc View 1 chunk +27 lines, -12 lines 0 comments Download
M content/browser/device_sensors/device_inertial_sensor_browsertest.cc View 2 chunks +16 lines, -7 lines 0 comments Download
M content/browser/frame_host/debug_urls.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/gamepad/gamepad_test_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_unittest.cc View 6 chunks +18 lines, -6 lines 0 comments Download
M content/browser/media/capture/web_contents_audio_input_stream_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/message_port_provider_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/net/quota_policy_cookie_store_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/child_process.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/devtools/v8_sampling_profiler_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_encoder.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M dbus/bus.cc View 1 chunk +2 lines, -1 line 0 comments Download
M dbus/test_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/dns/mock_host_resolver_creator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 4 chunks +13 lines, -5 lines 0 comments Download
M gpu/command_buffer/tests/egl_test.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 8 chunks +59 lines, -26 lines 0 comments Download
M ipc/ipc_sync_message.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M jingle/glue/thread_wrapper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M jingle/glue/thread_wrapper_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M media/audio/audio_output_device.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/clockless_audio_sink.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/audio/scoped_task_runner_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M media/audio/virtual_audio_output_stream_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/audio_renderer_mixer_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/base/bind_to_current_loop_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/pipeline_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/logging/log_event_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/test/utility/in_process_receiver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M media/filters/blocking_url_protocol.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/address_tracker_linux_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M net/base/keygen_handler_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/disk_cache/blockfile/backend_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/disk_cache/blockfile/in_flight_io.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/dns/serial_worker_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M net/log/net_log_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/server_thread.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M ppapi/host/resource_message_filter_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 4 chunks +13 lines, -5 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy_perftest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_messaging_proxy_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/tracked_callback_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ppapi/proxy/video_encoder_resource_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M remoting/base/auto_thread.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 1 chunk +3 lines, -1 line 0 comments Download
M services/shell/background/background_shell.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/runner/host/child_process_base.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M services/shell/runner/host/child_process_host.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M services/shell/standalone/tracer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M storage/common/database/database_connections.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/http_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 4 chunks +21 lines, -7 lines 0 comments Download
M sync/internal_api/public/base/cancelation_signal_unittest.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/syncapi_server_connection_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sync/test/fake_server/fake_server_http_post_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/battor_agent/battor_agent_bin.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/input_file_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (4 generated)
gab
Etienne/Francois FYI, will be splitting this CL and send to component OWNERS for review.
4 years, 6 months ago (2016-05-30 21:03:20 UTC) #5
gab
FYI: patch set 1 was applying the fix across the entire codebase @r396726 on a ...
4 years, 6 months ago (2016-05-31 12:34:57 UTC) #6
gab
4 years, 6 months ago (2016-06-07 15:46:01 UTC) #7
On 2016/05/31 12:34:57, gab wrote:
> FYI: patch set 1 was applying the fix across the entire codebase @r396726 on a
> Linux+Release+component out dir with no build.
> 
> A few files couldn't be assessed by clang-tidy per compile failures for lack
of
> generated headers.
> 
> I then built the "chrome" target and re-ran the fix on the codebase which
fixed
> 7 more files (ref. patch set 2:
> https://codereview.chromium.org/2024723002/#ps20001).

All of these landed. Closing.

Powered by Google App Engine
This is Rietveld 408576698