services/shell/background/background_shell.cc - Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/background/background_shell.cc

Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: fix presubmits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc ('k') | services/shell/runner/host/child_process_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/shell/background/background_shell.cc

diff --git a/services/shell/background/background_shell.cc b/services/shell/background/background_shell.cc

index 4c42c09dda5f785c299cb5f544d10dcef8e94e5a..bed732b068f1bdf26074cfec54c02512ace79e4a 100644

--- a/services/shell/background/background_shell.cc

+++ b/services/shell/background/background_shell.cc

@@ -151,7 +151,8 @@ mojom::ShellClientRequest BackgroundShell::CreateShellClientRequest(

params->set_source(CreateShellIdentity());

params->set_target(Identity(name, mojom::kRootUserID));

mojom::ShellClientRequest request;

- base::WaitableEvent signal(true, false);

+ base::WaitableEvent signal(base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

thread_->message_loop()->task_runner()->PostTask(

FROM_HERE, base::Bind(&MojoThread::CreateShellClientRequest,

base::Unretained(thread_.get()), &signal, name,