chrome/browser/sync/test/integration/single_client_directory_sync_test.cc - Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_directory_sync_test.cc

Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: fix presubmits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/passwords_helper.cc ('k') | chrome/browser/sync/test/integration/typed_urls_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_directory_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_directory_sync_test.cc b/chrome/browser/sync/test/integration/single_client_directory_sync_test.cc

index 71796bb164d3ce046e936dee0af9a19522e922a9..4d8ae9b4b129d920e03392651df57ecd959d0726 100644

--- a/chrome/browser/sync/test/integration/single_client_directory_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_directory_sync_test.cc

@@ -39,7 +39,8 @@ void SignalEvent(base::WaitableEvent* e) {

}

bool WaitForExistingTasksOnLoop(base::MessageLoop* loop) {

- base::WaitableEvent e(true, false);

+ base::WaitableEvent e(base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

loop->task_runner()->PostTask(FROM_HERE, base::Bind(&SignalEvent, &e));

// Timeout stolen from StatusChangeChecker::GetTimeoutDuration().

return e.TimedWait(base::TimeDelta::FromSeconds(45));