gpu/command_buffer/common/gles2_cmd_format_test.cc - Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/common/gles2_cmd_format_test.cc

Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: fix presubmits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/sockets_udp/sockets_udp_apitest.cc ('k') | gpu/command_buffer/service/in_process_command_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/common/gles2_cmd_format_test.cc

diff --git a/gpu/command_buffer/common/gles2_cmd_format_test.cc b/gpu/command_buffer/common/gles2_cmd_format_test.cc

index 4403886486e3713b0ab272505c6c28de60e30ed2..15a8670eb0305382b609f3dfd5398660150bf584 100644

--- a/gpu/command_buffer/common/gles2_cmd_format_test.cc

+++ b/gpu/command_buffer/common/gles2_cmd_format_test.cc

@@ -105,7 +105,9 @@ TEST(GLES2FormatAsyncUploadSyncTest, AsyncUploadSync) {

}

// Flush the thread message loop before starting again.

- base::WaitableEvent waitable(false, false);

+ base::WaitableEvent waitable(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

thread.task_runner()->PostTask(

FROM_HERE,

base::Bind(&base::WaitableEvent::Signal, base::Unretained(&waitable)));