chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: fix presubmits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index ddede93cf1f9947558069476e2eed43f5c84e5f1..ee4a20bfba7d1bc12a7b097b0f36971a832750f9 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -714,7 +714,9 @@ class HTML5FileWriter {

}

// Invoke the fileapi to copy it into the sandboxed filesystem.

bool result = false;

- base::WaitableEvent done_event(true, false);

+ base::WaitableEvent done_event(

+ base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

BrowserThread::PostTask(

BrowserThread::IO, FROM_HERE,

base::Bind(&CreateFileForTestingOnIOThread,

« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/extensions/api/socket/socket_apitest.cc » ('j') | no next file with comments »