chrome/common/service_process_util_posix.cc - Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_posix.cc

Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: fix presubmits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc ('k') | chrome/service/service_ipc_server_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/service_process_util_posix.cc

diff --git a/chrome/common/service_process_util_posix.cc b/chrome/common/service_process_util_posix.cc

index 024340f75d306a5c41180a4ba98df424e01d0a8d..9bd3783c4a9523f83aff16d8c482def1b75b486c 100644

--- a/chrome/common/service_process_util_posix.cc

+++ b/chrome/common/service_process_util_posix.cc

@@ -182,7 +182,9 @@ bool ServiceProcessState::SignalReady(base::SingleThreadTaskRunner* task_runner,

DPLOG(ERROR) << "pipe";

return false;

}

- base::WaitableEvent signal_ready(true, false);

+ base::WaitableEvent signal_ready(

+ base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

bool success = false;

task_runner->PostTask(FROM_HERE,