content/browser/appcache/appcache_request_handler_unittest.cc - Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_request_handler_unittest.cc

Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: fix presubmits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/shared_change_processor_unittest.cc ('k') | content/browser/appcache/appcache_response_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_request_handler_unittest.cc

diff --git a/content/browser/appcache/appcache_request_handler_unittest.cc b/content/browser/appcache/appcache_request_handler_unittest.cc

index eec35053dfca5e41d35208b390f44130aa9d9ee6..ffb58da607706c81e4c4c9d4faaaa09b9021382b 100644

--- a/content/browser/appcache/appcache_request_handler_unittest.cc

+++ b/content/browser/appcache/appcache_request_handler_unittest.cc

@@ -184,7 +184,9 @@ class AppCacheRequestHandlerTest : public testing::Test {

template <class Method>

void RunTestOnIOThread(Method method) {

- test_finished_event_ .reset(new base::WaitableEvent(false, false));

+ test_finished_event_.reset(new base::WaitableEvent(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED));

io_thread_->task_runner()->PostTask(

FROM_HERE,

base::Bind(&AppCacheRequestHandlerTest::MethodWrapper<Method>,