extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc - Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

Issue 2024723002: DO NOT COMMIT (will be split in sub-components) - clang-tidy WaitableEvent refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: fix presubmits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc ('k') | extensions/browser/api/sockets_udp/sockets_udp_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

diff --git a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

index cff342458a82160314078614b33e15f75b3c62fe..e076db9b84eff83e1239ddcaafadd491475d520e 100644

--- a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

+++ b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

@@ -25,7 +25,8 @@ const int kPort = 8888;

class SocketsTcpServerApiTest : public ShellApiTest {

public:

SocketsTcpServerApiTest()

- : resolver_event_(true, false),

+ : resolver_event_(base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED),

resolver_creator_(new MockHostResolverCreator()) {}

void SetUpOnMainThread() override {