Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2013133002: Avoid nesting steps called under waiting for x: (Closed)

Created:
4 years, 7 months ago by RobertoCN
Modified:
4 years, 6 months ago
Reviewers:
prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Avoid nesting steps called under waiting for x: R=prasadv BUG=602839 Committed: https://chromium.googlesource.com/chromium/tools/build/+/401e4870781011473779383953a9ef82792bda08

Patch Set 1 #

Patch Set 2 : Hiding changes behind optional parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+773 lines, -1517 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/api.py View 1 4 chunks +9 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/bisector.py View 1 2 chunks +21 lines, -16 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.py View 1 4 chunks +16 lines, -18 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json View 22 chunks +32 lines, -107 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json View 22 chunks +32 lines, -107 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 22 chunks +32 lines, -107 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json View 22 chunks +32 lines, -107 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json View 12 chunks +129 lines, -71 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json View 6 chunks +81 lines, -57 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json View 18 chunks +18 lines, -102 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json View 22 chunks +32 lines, -107 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json View 11 chunks +11 lines, -65 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json View 22 chunks +32 lines, -107 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json View 22 chunks +32 lines, -107 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json View 22 chunks +32 lines, -107 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/local_bisect.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisect.py View 1 2 chunks +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic.json View 28 chunks +75 lines, -103 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic_return_code_test.json View 24 chunks +67 lines, -95 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json View 12 chunks +41 lines, -61 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_good_revision_test.json View 12 chunks +41 lines, -61 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
RobertoCN
PTAL
4 years, 7 months ago (2016-05-26 18:25:37 UTC) #1
prasadv
lgtm
4 years, 7 months ago (2016-05-26 22:08:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013133002/1
4 years, 7 months ago (2016-05-26 22:42:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/401e4870781011473779383953a9ef82792bda08
4 years, 7 months ago (2016-05-26 22:50:43 UTC) #6
RobertoCN
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2016363003/ by robertocn@chromium.org. ...
4 years, 6 months ago (2016-05-27 18:26:28 UTC) #7
RobertoCN
4 years, 6 months ago (2016-05-27 18:26:31 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2020543003/ by robertocn@chromium.org.

The reason for reverting is: Broke downstream expectations.

https://bugs.chromium.org/p/chromium/issues/detail?id=615463.

Powered by Google App Engine
This is Rietveld 408576698