Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json

Issue 2013133002: Avoid nesting steps called under waiting for x: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Hiding changes behind optional parameter Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json ('k') | scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json
diff --git a/scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json b/scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json
index 39d45fbcd71d765700326eb855c21f480b70a0b3..28e3222311ada351358b7cb1c7c11175ce2b0cd9 100644
--- a/scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json
+++ b/scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json
@@ -197,46 +197,32 @@
"ls",
"gs://chrome-perf/Linux Builder/full-build-linux_00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111.zip"
],
- "name": "gsutil ls (2)"
- },
- {
- "cmd": [],
- "name": "Triggering test job for 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
- "trigger_specs": [
- {
- "builder_name": "linux_perf_tester",
- "properties": {
- "bisect_config": {
- "command": "src/tools/perf/run_benchmark -v --browser=release smoothness.tough_scrolling_cases",
- "metric": "mean_input_event_latency/mean_input_event_latency",
- "repeat_count": 5,
- "test_type": "perf"
- },
- "job_name": "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-test",
- "parent_build_archive_url": "gs://chrome-perf/Linux Builder/full-build-linux_00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111.zip",
- "parent_got_revision": "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
- "revision": "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
- "revision_ladder": {
- "chromium": "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111"
- }
- }
- }
+ "name": "gsutil ls (2)",
+ "~followup_annotations": [
+ "step returned non-zero exit code: 1",
+ "@@@STEP_EXCEPTION@@@"
]
},
{
"cmd": [
"git",
- "footers",
- "--position",
- "a6298e4afedbf2cd461755ea6f45b0ad64222222"
+ "-c",
+ "user.email=FAKE_PERF_PUMPKIN@chromium.org",
+ "try",
+ "--bot",
+ "linux_perf_bisect_builder",
+ "--revision",
+ "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "--name",
+ "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-build",
+ "--clobber",
+ "--svn_repo",
+ "svn://svn.chromium.org/chrome-try/try-perf",
+ "--diff",
+ "/dev/null"
],
"cwd": "[TMP_BASE]/fake_checkout_tmp_1",
- "name": "resolving hash a6298e4afedbf2cd461755ea6f45b0ad64222222",
- "stdout": "/path/to/tmp/"
- },
- {
- "cmd": [],
- "name": "Waiting for chromium@a6298e4afe"
+ "name": "Requesting build for 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111 via git try."
},
{
"cmd": [
@@ -249,9 +235,8 @@
"ls",
"gs://chrome-perf/Linux Builder/full-build-linux_a6298e4afedbf2cd461755ea6f45b0ad64222222.zip"
],
- "name": "Waiting for chromium@a6298e4afe.gsutil ls",
+ "name": "gsutil ls (3)",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"step returned non-zero exit code: 1",
"@@@STEP_EXCEPTION@@@"
]
@@ -265,10 +250,7 @@
"--outfile",
"/path/to/tmp/"
],
- "name": "Waiting for chromium@a6298e4afe.fetch builder state",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "fetch builder state"
},
{
"cmd": [
@@ -276,9 +258,8 @@
"-u",
"\nimport sys\nimport time\ntime.sleep(20*60)\nsys.exit(0)\n"
],
- "name": "Waiting for chromium@a6298e4afe.sleeping",
+ "name": "sleeping",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@python.inline@@@@",
"@@@STEP_LOG_LINE@python.inline@import sys@@@",
"@@@STEP_LOG_LINE@python.inline@import time@@@",
@@ -298,9 +279,8 @@
"ls",
"gs://chrome-perf/Linux Builder/full-build-linux_a6298e4afedbf2cd461755ea6f45b0ad64222222.zip"
],
- "name": "Waiting for chromium@a6298e4afe.gsutil ls (2)",
+ "name": "gsutil ls (4)",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"step returned non-zero exit code: 1",
"@@@STEP_EXCEPTION@@@"
]
@@ -314,10 +294,7 @@
"--outfile",
"/path/to/tmp/"
],
- "name": "Waiting for chromium@a6298e4afe.fetch builder state (2)",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "fetch builder state (2)"
},
{
"cmd": [
@@ -328,10 +305,7 @@
"--outfile",
"/path/to/tmp/"
],
- "name": "Waiting for chromium@a6298e4afe.fetch build details",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "fetch build details"
},
{
"cmd": [
@@ -339,9 +313,8 @@
"-u",
"\nimport sys\nimport time\ntime.sleep(20*60)\nsys.exit(0)\n"
],
- "name": "Waiting for chromium@a6298e4afe.sleeping (2)",
+ "name": "sleeping (2)",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@python.inline@@@@",
"@@@STEP_LOG_LINE@python.inline@import sys@@@",
"@@@STEP_LOG_LINE@python.inline@import time@@@",
@@ -361,9 +334,8 @@
"ls",
"gs://chrome-perf/Linux Builder/full-build-linux_a6298e4afedbf2cd461755ea6f45b0ad64222222.zip"
],
- "name": "Waiting for chromium@a6298e4afe.gsutil ls (3)",
+ "name": "gsutil ls (5)",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"step returned non-zero exit code: 1",
"@@@STEP_EXCEPTION@@@"
]
@@ -377,25 +349,51 @@
"--outfile",
"/path/to/tmp/"
],
- "name": "Waiting for chromium@a6298e4afe.fetch build details (2)",
+ "name": "fetch build details (2)"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "RECIPE_MODULE[build::gsutil]/resources/gsutil_wrapper.py",
+ "--",
+ "[DEPOT_TOOLS]/gsutil.py",
+ "----",
+ "ls",
+ "gs://chrome-perf/Linux Builder/full-build-linux_00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111.zip"
+ ],
+ "name": "gsutil ls (6)",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
+ "step returned non-zero exit code: 1",
+ "@@@STEP_EXCEPTION@@@"
]
},
{
"cmd": [
- "git",
- "footers",
- "--position",
- "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111"
+ "python",
+ "-u",
+ "RECIPE_PACKAGE_REPO[build]/scripts/tools/pycurl.py",
+ "https://build.chromium.org/p/tryserver.chromium.perfjson/builders/linux_perf_bisect_builder?as_text=1",
+ "--outfile",
+ "/path/to/tmp/"
],
- "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
- "name": "resolving hash 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
- "stdout": "/path/to/tmp/"
+ "name": "fetch builder state (3)"
},
{
- "cmd": [],
- "name": "Waiting for chromium@00316c9ddf"
+ "cmd": [
+ "python",
+ "-u",
+ "\nimport sys\nimport time\ntime.sleep(20*60)\nsys.exit(0)\n"
+ ],
+ "name": "sleeping (3)",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@import sys@@@",
+ "@@@STEP_LOG_LINE@python.inline@import time@@@",
+ "@@@STEP_LOG_LINE@python.inline@time.sleep(20*60)@@@",
+ "@@@STEP_LOG_LINE@python.inline@sys.exit(0)@@@",
+ "@@@STEP_LOG_END@python.inline@@@"
+ ]
},
{
"cmd": [
@@ -406,11 +404,48 @@
"[DEPOT_TOOLS]/gsutil.py",
"----",
"ls",
- "gs://chrome-perf/bisect-results/00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-test.results"
+ "gs://chrome-perf/Linux Builder/full-build-linux_00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111.zip"
+ ],
+ "name": "gsutil ls (7)"
+ },
+ {
+ "cmd": [],
+ "name": "Triggering test job for 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "trigger_specs": [
+ {
+ "builder_name": "linux_perf_tester",
+ "properties": {
+ "bisect_config": {
+ "command": "src/tools/perf/run_benchmark -v --browser=release smoothness.tough_scrolling_cases",
+ "metric": "mean_input_event_latency/mean_input_event_latency",
+ "repeat_count": 5,
+ "test_type": "perf"
+ },
+ "job_name": "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-test",
+ "parent_build_archive_url": "gs://chrome-perf/Linux Builder/full-build-linux_00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111.zip",
+ "parent_got_revision": "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "revision": "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "revision_ladder": {
+ "chromium": "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111"
+ }
+ }
+ }
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "\nimport sys\nimport time\ntime.sleep(20*60)\nsys.exit(0)\n"
],
- "name": "Waiting for chromium@00316c9ddf.gsutil ls",
+ "name": "sleeping (4)",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@import sys@@@",
+ "@@@STEP_LOG_LINE@python.inline@import time@@@",
+ "@@@STEP_LOG_LINE@python.inline@time.sleep(20*60)@@@",
+ "@@@STEP_LOG_LINE@python.inline@sys.exit(0)@@@",
+ "@@@STEP_LOG_END@python.inline@@@"
]
},
{
@@ -421,13 +456,36 @@
"--",
"[DEPOT_TOOLS]/gsutil.py",
"----",
+ "ls",
+ "gs://chrome-perf/bisect-results/00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-test.results"
+ ],
+ "name": "gsutil ls (8)"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "RECIPE_MODULE[build::gsutil]/resources/gsutil_wrapper.py",
+ "--",
+ "[DEPOT_TOOLS]/gsutil.py",
+ "----",
"cat",
"gs://chrome-perf/bisect-results/00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-test.results"
],
- "name": "Waiting for chromium@00316c9ddf.gsutil Get test results for build 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "name": "gsutil Get test results for build 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "stdout": "/path/to/tmp/"
+ },
+ {
+ "cmd": [
+ "git",
+ "footers",
+ "--position",
+ "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111"
+ ],
+ "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
+ "name": "resolving hash 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
"stdout": "/path/to/tmp/",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@SET_BUILD_PROPERTY@extra_result_code@[\"B4T_TEST_FAILURE\"]@@@"
]
},
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json ('k') | scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698