scripts/slave/recipes/bisection/desktop_bisect.py - Issue 2013133002: Avoid nesting steps called under waiting for x:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisection/desktop_bisect.py

Issue 2013133002: Avoid nesting steps called under waiting for x: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Hiding changes behind optional parameter Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/bisection/desktop_bisect.py

diff --git a/scripts/slave/recipes/bisection/desktop_bisect.py b/scripts/slave/recipes/bisection/desktop_bisect.py

index 43f5f80f049e56623a16c387398b427caacdbfe2..9c4440333b17b14f29454ad5506adedbc72e2659 100644

--- a/scripts/slave/recipes/bisection/desktop_bisect.py

+++ b/scripts/slave/recipes/bisection/desktop_bisect.py

@@ -26,8 +26,11 @@ def RunSteps(api):

buildername)

api.chromium_tests.configure_build(bot_config)

api.gclient.apply_config('perf')

+ # TODO(robertocn): remove do_not_nest_wait_for_revision once downstream

+ # expectations have been fixed, and make it behave like this by default.

update_step, bot_db = api.chromium_tests.prepare_checkout(bot_config)

- api.auto_bisect.start_try_job(api, update_step=update_step, bot_db=bot_db)

+ api.auto_bisect.start_try_job(api, update_step=update_step, bot_db=bot_db,

+ do_not_nest_wait_for_revision=True)

def GenTests(api):

« no previous file with comments | « scripts/slave/recipes/bisect.expected/broken_good_revision_test.json ('k') | no next file » | no next file with comments »