scripts/slave/recipe_modules/auto_bisect/local_bisect.py - Issue 2013133002: Avoid nesting steps called under waiting for x:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/local_bisect.py

Issue 2013133002: Avoid nesting steps called under waiting for x: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Hiding changes behind optional parameter Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json ('k') | scripts/slave/recipes/bisect.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/auto_bisect/local_bisect.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/local_bisect.py b/scripts/slave/recipe_modules/auto_bisect/local_bisect.py

index eac281d00f7592072c30d2c33c2a428948af9691..c5fb2cc8d93d65c0d111a9420be62228f68ddc0e 100644

--- a/scripts/slave/recipe_modules/auto_bisect/local_bisect.py

+++ b/scripts/slave/recipe_modules/auto_bisect/local_bisect.py

@@ -7,10 +7,10 @@ import collections

import json

-def perform_bisect(api): # pragma: no cover

+def perform_bisect(api, **flags): # pragma: no cover

bisect_config = api.m.properties.get('bisect_config')

assert isinstance(bisect_config, collections.Mapping)

- bisector = api.create_bisector(bisect_config)

+ bisector = api.create_bisector(bisect_config, **flags)

with api.m.step.nest('Gathering reference values'):

_gather_reference_range(api, bisector)

if (not bisector.failed and bisector.check_improvement_direction() and