Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/api.py

Issue 2013133002: Avoid nesting steps called under waiting for x: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Hiding changes behind optional parameter Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/bisector.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/api.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/api.py b/scripts/slave/recipe_modules/auto_bisect/api.py
index 48cc717c87f7b1f15caf584a3995786e7c0450aa..50a988604643b054915ade4a23ffb5d5fbefc467 100644
--- a/scripts/slave/recipe_modules/auto_bisect/api.py
+++ b/scripts/slave/recipe_modules/auto_bisect/api.py
@@ -46,10 +46,10 @@ class AutoBisectApi(recipe_api.RecipeApi):
self.builder_bot = None
self.full_deploy_script = None
- def perform_bisect(self):
- return local_bisect.perform_bisect(self)
+ def perform_bisect(self, **flags):
+ return local_bisect.perform_bisect(self, **flags)
- def create_bisector(self, bisect_config_dict, dummy_mode=False):
+ def create_bisector(self, bisect_config_dict, dummy_mode=False, **flags):
"""Passes the api and the config dictionary to the Bisector constructor.
For details about the keys in the bisect config dictionary go to:
@@ -67,7 +67,7 @@ class AutoBisectApi(recipe_api.RecipeApi):
self.override_poll_interval = bisect_config_dict.get('poll_sleep')
return bisector.Bisector(self, bisect_config_dict,
revision_state.RevisionState,
- init_revisions=not dummy_mode)
+ init_revisions=not dummy_mode, **flags)
def set_platform_gs_prefix(self, gs_url):
"""Sets GS path for the platform."""
@@ -351,6 +351,10 @@ class AutoBisectApi(recipe_api.RecipeApi):
bot_db: A BotConfigAndTestDB object, used for some job types.
kwargs: Args to use only for legacy bisect.
"""
+ flags = {}
+ if kwargs.get('do_not_nest_wait_for_revision'):
+ flags['do_not_nest_wait_for_revision'] = kwargs.pop(
+ 'do_not_nest_wait_for_revision')
if bot_db is None: # pragma: no cover
self.bot_db = api.chromium_tests.create_bot_db_from_master_dict(
'', None, None)
@@ -371,7 +375,7 @@ class AutoBisectApi(recipe_api.RecipeApi):
# We can distinguish between a config for a full bisect vs a single
# test by checking for the presence of the good_revision key.
if api.properties.get('bisect_config').get('good_revision'):
- local_bisect.perform_bisect(self) # pragma: no cover
+ local_bisect.perform_bisect(self, **flags) # pragma: no cover
else:
self.start_test_run_for_bisect(update_step, self.bot_db,
api.properties)
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/bisector.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698