Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json

Issue 2013133002: Avoid nesting steps called under waiting for x: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Hiding changes behind optional parameter Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json ('k') | scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json
diff --git a/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json b/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json
index 54dd3d1d3dcc6ef4d3507041674abd094b015a77..909752a79c71076dd713fc06ce318db5ad2db438 100644
--- a/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json
+++ b/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json
@@ -225,21 +225,6 @@
},
{
"cmd": [
- "git",
- "footers",
- "--position",
- "a6298e4afedbf2cd461755ea6f45b0ad64222222"
- ],
- "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
- "name": "resolving hash a6298e4afedbf2cd461755ea6f45b0ad64222222",
- "stdout": "/path/to/tmp/"
- },
- {
- "cmd": [],
- "name": "Waiting for chromium@a6298e4afe"
- },
- {
- "cmd": [
"python",
"-u",
"RECIPE_MODULE[build::gsutil]/resources/gsutil_wrapper.py",
@@ -249,14 +234,11 @@
"ls",
"gs://chrome-perf/Win Builder/full-build-win32_a6298e4afedbf2cd461755ea6f45b0ad64222222.zip"
],
- "name": "Waiting for chromium@a6298e4afe.gsutil ls",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (3)"
},
{
"cmd": [],
- "name": "Waiting for chromium@a6298e4afe.Triggering test job for a6298e4afedbf2cd461755ea6f45b0ad64222222",
+ "name": "Triggering test job for a6298e4afedbf2cd461755ea6f45b0ad64222222",
"trigger_specs": [
{
"builder_name": "chromium_rel_win7",
@@ -276,9 +258,6 @@
}
}
}
- ],
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
]
},
{
@@ -287,9 +266,8 @@
"-u",
"\nimport sys\nimport time\ntime.sleep(20*60)\nsys.exit(0)\n"
],
- "name": "Waiting for chromium@a6298e4afe.sleeping",
+ "name": "sleeping",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@python.inline@@@@",
"@@@STEP_LOG_LINE@python.inline@import sys@@@",
"@@@STEP_LOG_LINE@python.inline@import time@@@",
@@ -309,10 +287,7 @@
"ls",
"gs://chrome-perf/bisect-results/a6298e4afedbf2cd461755ea6f45b0ad64222222-test.results"
],
- "name": "Waiting for chromium@a6298e4afe.gsutil ls (2)",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (4)"
},
{
"cmd": [
@@ -325,28 +300,10 @@
"cat",
"gs://chrome-perf/bisect-results/a6298e4afedbf2cd461755ea6f45b0ad64222222-test.results"
],
- "name": "Waiting for chromium@a6298e4afe.gsutil Get test results for build a6298e4afedbf2cd461755ea6f45b0ad64222222",
- "stdout": "/path/to/tmp/",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
- },
- {
- "cmd": [
- "git",
- "footers",
- "--position",
- "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111"
- ],
- "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
- "name": "resolving hash 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "name": "gsutil Get test results for build a6298e4afedbf2cd461755ea6f45b0ad64222222",
"stdout": "/path/to/tmp/"
},
{
- "cmd": [],
- "name": "Waiting for chromium@00316c9ddf"
- },
- {
"cmd": [
"python",
"-u",
@@ -357,14 +314,11 @@
"ls",
"gs://chrome-perf/Win Builder/full-build-win32_00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111.zip"
],
- "name": "Waiting for chromium@00316c9ddf.gsutil ls",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (5)"
},
{
"cmd": [],
- "name": "Waiting for chromium@00316c9ddf.Triggering test job for 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "name": "Triggering test job for 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
"trigger_specs": [
{
"builder_name": "chromium_rel_win7",
@@ -384,9 +338,6 @@
}
}
}
- ],
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
]
},
{
@@ -395,9 +346,8 @@
"-u",
"\nimport sys\nimport time\ntime.sleep(20*60)\nsys.exit(0)\n"
],
- "name": "Waiting for chromium@00316c9ddf.sleeping",
+ "name": "sleeping (2)",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@python.inline@@@@",
"@@@STEP_LOG_LINE@python.inline@import sys@@@",
"@@@STEP_LOG_LINE@python.inline@import time@@@",
@@ -417,10 +367,7 @@
"ls",
"gs://chrome-perf/bisect-results/00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-test.results"
],
- "name": "Waiting for chromium@00316c9ddf.gsutil ls (2)",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (6)"
},
{
"cmd": [
@@ -433,11 +380,8 @@
"cat",
"gs://chrome-perf/bisect-results/00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-test.results"
],
- "name": "Waiting for chromium@00316c9ddf.gsutil Get test results for build 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
- "stdout": "/path/to/tmp/",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil Get test results for build 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "stdout": "/path/to/tmp/"
},
{
"cmd": [
@@ -450,7 +394,7 @@
"ls",
"gs://chrome-perf/Win Builder/full-build-win32_dcdcdc0ff1122212323134879ddceeb1240b0988.zip"
],
- "name": "gsutil ls (3)"
+ "name": "gsutil ls (7)"
},
{
"cmd": [
@@ -475,21 +419,6 @@
},
{
"cmd": [
- "git",
- "footers",
- "--position",
- "dcdcdc0ff1122212323134879ddceeb1240b0988"
- ],
- "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
- "name": "resolving hash dcdcdc0ff1122212323134879ddceeb1240b0988",
- "stdout": "/path/to/tmp/"
- },
- {
- "cmd": [],
- "name": "Waiting for chromium@dcdcdc0ff1"
- },
- {
- "cmd": [
"python",
"-u",
"RECIPE_MODULE[build::gsutil]/resources/gsutil_wrapper.py",
@@ -499,14 +428,11 @@
"ls",
"gs://chrome-perf/Win Builder/full-build-win32_dcdcdc0ff1122212323134879ddceeb1240b0988.zip"
],
- "name": "Waiting for chromium@dcdcdc0ff1.gsutil ls",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (8)"
},
{
"cmd": [],
- "name": "Waiting for chromium@dcdcdc0ff1.Triggering test job for dcdcdc0ff1122212323134879ddceeb1240b0988",
+ "name": "Triggering test job for dcdcdc0ff1122212323134879ddceeb1240b0988",
"trigger_specs": [
{
"builder_name": "chromium_rel_win7",
@@ -526,9 +452,6 @@
}
}
}
- ],
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
]
},
{
@@ -537,9 +460,8 @@
"-u",
"\nimport sys\nimport time\ntime.sleep(20*60)\nsys.exit(0)\n"
],
- "name": "Waiting for chromium@dcdcdc0ff1.sleeping",
+ "name": "sleeping (3)",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@python.inline@@@@",
"@@@STEP_LOG_LINE@python.inline@import sys@@@",
"@@@STEP_LOG_LINE@python.inline@import time@@@",
@@ -559,10 +481,7 @@
"ls",
"gs://chrome-perf/bisect-results/dcdcdc0ff1122212323134879ddceeb1240b0988-test.results"
],
- "name": "Waiting for chromium@dcdcdc0ff1.gsutil ls (2)",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (9)"
},
{
"cmd": [
@@ -575,11 +494,8 @@
"cat",
"gs://chrome-perf/bisect-results/dcdcdc0ff1122212323134879ddceeb1240b0988-test.results"
],
- "name": "Waiting for chromium@dcdcdc0ff1.gsutil Get test results for build dcdcdc0ff1122212323134879ddceeb1240b0988",
- "stdout": "/path/to/tmp/",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil Get test results for build dcdcdc0ff1122212323134879ddceeb1240b0988",
+ "stdout": "/path/to/tmp/"
},
{
"cmd": [
@@ -590,10 +506,9 @@
"[12, 13, 14, 15, 16]",
"0.01"
],
- "name": "Waiting for chromium@dcdcdc0ff1.Checking sample difference",
+ "name": "Checking sample difference",
"stdout": "/path/to/tmp/json",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
"@@@STEP_LOG_END@json.output (invalid)@@@"
]
@@ -607,10 +522,9 @@
"[12, 13, 14, 15, 16]",
"0.01"
],
- "name": "Waiting for chromium@dcdcdc0ff1.Checking sample difference (2)",
+ "name": "Checking sample difference (2)",
"stdout": "/path/to/tmp/json",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
"@@@STEP_LOG_END@json.output (invalid)@@@"
]
@@ -731,6 +645,17 @@
"stdout": "/path/to/tmp/"
},
{
+ "cmd": [
+ "git",
+ "footers",
+ "--position",
+ "a6298e4afedbf2cd461755ea6f45b0ad64222222"
+ ],
+ "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
+ "name": "resolving hash a6298e4afedbf2cd461755ea6f45b0ad64222222",
+ "stdout": "/path/to/tmp/"
+ },
+ {
"cmd": [],
"name": "Wiggling revision chromium@a6298e4afe,v8@003"
},
@@ -745,7 +670,7 @@
"ls",
"gs://chrome-perf/Win Builder/full-build-win32_a6298e4afedbf2cd461755ea6f45b0ad64222222_51e7ed4b63ad81d8b499e42b888149349afaaca1.zip"
],
- "name": "gsutil ls (4)"
+ "name": "gsutil ls (10)"
},
{
"cmd": [
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json ('k') | scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698