scripts/slave/recipes/bisect.py - Issue 2013133002: Avoid nesting steps called under waiting for x:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisect.py

Issue 2013133002: Avoid nesting steps called under waiting for x: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Hiding changes behind optional parameter Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/bisect.py

diff --git a/scripts/slave/recipes/bisect.py b/scripts/slave/recipes/bisect.py

index 22193ffcf7c1484a423f346e71b8f71d84a465c2..84f1bd2a7de32cb05b42971450affe488f93662d 100644

--- a/scripts/slave/recipes/bisect.py

+++ b/scripts/slave/recipes/bisect.py

@@ -26,7 +26,7 @@ def RunSteps(api):

mastername, buildername)

api.chromium_tests.configure_build(bot_config)

api.m.chromium_tests.prepare_checkout(bot_config)

- api.auto_bisect.perform_bisect()

+ api.auto_bisect.perform_bisect(do_not_nest_wait_for_revision=True)

def GenTests(api):

basic_test = api.test('basic')

@@ -272,9 +272,7 @@ def _get_step_data_for_revision(api, revision_data, skip_results=False):

stdout=api.json.output({'git_sha': commit_hash}))

if not skip_results:

- step_name = ('Waiting for chromium@%s.gsutil '

- 'Get test results for build %s') % (commit_hash[:10],

- commit_hash)

+ step_name = ('gsutil Get test results for build %s') % (commit_hash)

if 'refrange' in revision_data:

parent_step = 'Gathering reference values.'

else:

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/local_bisect.py ('k') | scripts/slave/recipes/bisect.expected/basic.json » ('j') | no next file with comments »