Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json

Issue 2013133002: Avoid nesting steps called under waiting for x: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Hiding changes behind optional parameter Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json
diff --git a/scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json b/scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json
index 00b8c5fc4bdc4a26e335c75184d52bc3ad8e3ae6..18e9b6ceda16b9f60963f665272d7cbeaafc4adf 100644
--- a/scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json
+++ b/scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json
@@ -218,21 +218,6 @@
},
{
"cmd": [
- "git",
- "footers",
- "--position",
- "a6298e4afedbf2cd461755ea6f45b0ad64222222"
- ],
- "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
- "name": "resolving hash a6298e4afedbf2cd461755ea6f45b0ad64222222",
- "stdout": "/path/to/tmp/"
- },
- {
- "cmd": [],
- "name": "Waiting for chromium@a6298e4afe"
- },
- {
- "cmd": [
"python",
"-u",
"RECIPE_MODULE[build::gsutil]/resources/gsutil_wrapper.py",
@@ -242,14 +227,11 @@
"ls",
"gs://chrome-perf/Linux Builder/full-build-linux_a6298e4afedbf2cd461755ea6f45b0ad64222222.zip"
],
- "name": "Waiting for chromium@a6298e4afe.gsutil ls",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (3)"
},
{
"cmd": [],
- "name": "Waiting for chromium@a6298e4afe.Triggering test job for a6298e4afedbf2cd461755ea6f45b0ad64222222",
+ "name": "Triggering test job for a6298e4afedbf2cd461755ea6f45b0ad64222222",
"trigger_specs": [
{
"builder_name": "linux_perf_tester",
@@ -269,9 +251,6 @@
}
}
}
- ],
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
]
},
{
@@ -280,9 +259,8 @@
"-u",
"\nimport sys\nimport time\ntime.sleep(20*60)\nsys.exit(0)\n"
],
- "name": "Waiting for chromium@a6298e4afe.sleeping",
+ "name": "sleeping",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@python.inline@@@@",
"@@@STEP_LOG_LINE@python.inline@import sys@@@",
"@@@STEP_LOG_LINE@python.inline@import time@@@",
@@ -302,10 +280,7 @@
"ls",
"gs://chrome-perf/bisect-results/a6298e4afedbf2cd461755ea6f45b0ad64222222-test.results"
],
- "name": "Waiting for chromium@a6298e4afe.gsutil ls (2)",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (4)"
},
{
"cmd": [
@@ -318,30 +293,14 @@
"cat",
"gs://chrome-perf/bisect-results/a6298e4afedbf2cd461755ea6f45b0ad64222222-test.results"
],
- "name": "Waiting for chromium@a6298e4afe.gsutil Get test results for build a6298e4afedbf2cd461755ea6f45b0ad64222222",
+ "name": "gsutil Get test results for build a6298e4afedbf2cd461755ea6f45b0ad64222222",
"stdout": "/path/to/tmp/",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@SET_BUILD_PROPERTY@extra_result_code@[\"B4T_MISSING_METRIC\"]@@@"
]
},
{
"cmd": [
- "git",
- "footers",
- "--position",
- "00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111"
- ],
- "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
- "name": "resolving hash 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
- "stdout": "/path/to/tmp/"
- },
- {
- "cmd": [],
- "name": "Waiting for chromium@00316c9ddf"
- },
- {
- "cmd": [
"python",
"-u",
"RECIPE_MODULE[build::gsutil]/resources/gsutil_wrapper.py",
@@ -351,14 +310,11 @@
"ls",
"gs://chrome-perf/Linux Builder/full-build-linux_00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111.zip"
],
- "name": "Waiting for chromium@00316c9ddf.gsutil ls",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (5)"
},
{
"cmd": [],
- "name": "Waiting for chromium@00316c9ddf.Triggering test job for 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "name": "Triggering test job for 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
"trigger_specs": [
{
"builder_name": "linux_perf_tester",
@@ -378,9 +334,6 @@
}
}
}
- ],
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
]
},
{
@@ -389,9 +342,8 @@
"-u",
"\nimport sys\nimport time\ntime.sleep(20*60)\nsys.exit(0)\n"
],
- "name": "Waiting for chromium@00316c9ddf.sleeping",
+ "name": "sleeping (2)",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@python.inline@@@@",
"@@@STEP_LOG_LINE@python.inline@import sys@@@",
"@@@STEP_LOG_LINE@python.inline@import time@@@",
@@ -411,10 +363,7 @@
"ls",
"gs://chrome-perf/bisect-results/00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-test.results"
],
- "name": "Waiting for chromium@00316c9ddf.gsutil ls (2)",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil ls (6)"
},
{
"cmd": [
@@ -427,11 +376,8 @@
"cat",
"gs://chrome-perf/bisect-results/00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111-test.results"
],
- "name": "Waiting for chromium@00316c9ddf.gsutil Get test results for build 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
- "stdout": "/path/to/tmp/",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
+ "name": "gsutil Get test results for build 00316c9ddfb9d7b4e1ed2fff9fe6d964d2111111",
+ "stdout": "/path/to/tmp/"
},
{
"name": "$result",

Powered by Google App Engine
This is Rietveld 408576698