Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: scripts/slave/recipes/bisection/desktop_bisect.py

Issue 2013133002: Avoid nesting steps called under waiting for x: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Hiding changes behind optional parameter Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « scripts/slave/recipes/bisect.expected/broken_good_revision_test.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'auto_bisect', 6 'auto_bisect',
7 'bisect_tester', 7 'bisect_tester',
8 'chromium', 8 'chromium',
9 'chromium_tests', 9 'chromium_tests',
10 'depot_tools/gclient', 10 'depot_tools/gclient',
11 'recipe_engine/json', 11 'recipe_engine/json',
12 'recipe_engine/path', 12 'recipe_engine/path',
13 'recipe_engine/platform', 13 'recipe_engine/platform',
14 'recipe_engine/properties', 14 'recipe_engine/properties',
15 'recipe_engine/raw_io', 15 'recipe_engine/raw_io',
16 'recipe_engine/step', 16 'recipe_engine/step',
17 ] 17 ]
18 18
19 19
20 def RunSteps(api): 20 def RunSteps(api):
21 mastername = api.properties.get('mastername') 21 mastername = api.properties.get('mastername')
22 buildername = api.properties.get('buildername') 22 buildername = api.properties.get('buildername')
23 # TODO(akuegel): Explicitly load the builder configs instead of relying on 23 # TODO(akuegel): Explicitly load the builder configs instead of relying on
24 # builder.py from chromium_tests recipe module. 24 # builder.py from chromium_tests recipe module.
25 bot_config = api.chromium_tests.create_bot_config_object(mastername, 25 bot_config = api.chromium_tests.create_bot_config_object(mastername,
26 buildername) 26 buildername)
27 api.chromium_tests.configure_build(bot_config) 27 api.chromium_tests.configure_build(bot_config)
28 api.gclient.apply_config('perf') 28 api.gclient.apply_config('perf')
29 # TODO(robertocn): remove do_not_nest_wait_for_revision once downstream
30 # expectations have been fixed, and make it behave like this by default.
29 update_step, bot_db = api.chromium_tests.prepare_checkout(bot_config) 31 update_step, bot_db = api.chromium_tests.prepare_checkout(bot_config)
30 api.auto_bisect.start_try_job(api, update_step=update_step, bot_db=bot_db) 32 api.auto_bisect.start_try_job(api, update_step=update_step, bot_db=bot_db,
33 do_not_nest_wait_for_revision=True)
31 34
32 35
33 def GenTests(api): 36 def GenTests(api):
34 yield (api.test('basic') + api.properties.tryserver( 37 yield (api.test('basic') + api.properties.tryserver(
35 mastername='tryserver.chromium.perf', 38 mastername='tryserver.chromium.perf',
36 buildername='linux_perf_bisect') + api.override_step_data( 39 buildername='linux_perf_bisect') + api.override_step_data(
37 'git diff to analyze patch', 40 'git diff to analyze patch',
38 api.raw_io.stream_output('tools/auto_bisect/bisect.cfg'))) 41 api.raw_io.stream_output('tools/auto_bisect/bisect.cfg')))
39 42
40 config_json = { 43 config_json = {
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 buildername='linux_perf_bisect') + 210 buildername='linux_perf_bisect') +
208 api.step_data('saving url to temp file', 211 api.step_data('saving url to temp file',
209 stdout=api.raw_io.output('/tmp/dummy1')) + api.step_data( 212 stdout=api.raw_io.output('/tmp/dummy1')) + api.step_data(
210 'saving json to temp file', 213 'saving json to temp file',
211 stdout=api.raw_io.output('/tmp/dummy2')) + 214 stdout=api.raw_io.output('/tmp/dummy2')) +
212 api.properties(bisect_config=bisect_ret_code_config) + api.properties( 215 api.properties(bisect_config=bisect_ret_code_config) + api.properties(
213 job_name='f7a7b4135624439cbd27fdd5133d74ec') + 216 job_name='f7a7b4135624439cbd27fdd5133d74ec') +
214 api.bisect_tester(tempfile='/tmp/dummy') + api.properties( 217 api.bisect_tester(tempfile='/tmp/dummy') + api.properties(
215 parent_got_revision='1111111') + api.properties( 218 parent_got_revision='1111111') + api.properties(
216 parent_build_archive_url='gs://test-domain/test-archive.zip')) 219 parent_build_archive_url='gs://test-domain/test-archive.zip'))
OLDNEW
« no previous file with comments | « scripts/slave/recipes/bisect.expected/broken_good_revision_test.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698