Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522
patch from issue 2003543002 at patchset 40001 (http://crrev.com/2003543002#ps40001)

Committed: https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e
Cr-Commit-Position: refs/heads/master@{#395291}

[Srirama, 2016-05-21 13:55:29]

Description was changed from

==========
media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515
Cr-Commit-Position: refs/heads/master@{#395078}

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

to

==========
media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515
Cr-Commit-Position: refs/heads/master@{#395078}

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

[Srirama, 2016-05-21 14:08:55]

Description was changed from

==========
media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515
Cr-Commit-Position: refs/heads/master@{#395078}

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

to

==========
Reland media/track: Replace wtf/Assertions.h macros in favor of base/logging.h
macros

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515
Cr-Commit-Position: refs/heads/master@{#395078}

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

[Srirama, 2016-05-21 14:10:58]

Description was changed from

==========
Reland media/track: Replace wtf/Assertions.h macros in favor of base/logging.h
macros

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515
Cr-Commit-Position: refs/heads/master@{#395078}

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

to

==========
Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h
macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515
Cr-Commit-Position: refs/heads/master@{#395078}

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

[Srirama, 2016-05-21 14:11:37]

srirama.m@samsung.com changed reviewers:
+ fs@opera.com

[Srirama, 2016-05-21 14:11:37]

PTAL.
Is there anyway we can start the crashed bot?

[fs, 2016-05-21 16:04:53]

On 2016/05/21 at 14:11:37, srirama.m wrote:
> PTAL.
> Is there anyway we can start the crashed bot?

Doesn't look like it. I think you could try building a (local) release build
making sure dcheck_always_on is false (or at least the 'html' target.)

Also, remove the old commit metadata ("Committed: ..." et.c)

https://codereview.chromium.org/2003433005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/TextTrack.cpp (right):

https://codereview.chromium.org/2003433005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrack.cpp:280: DCHECK(wasRemoved);
Let's try:

bool wasRemoved = ...;
DCHECK(wasRemoved);

this time.

At least if my reading of

https://code.google.com/p/chromium/codesearch#chromium/src/base/logging.h&q=D...

is correct, that ought to work out.

https://codereview.chromium.org/2003433005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp (right):

https://codereview.chromium.org/2003433005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp:784: DCHECK(check);
Ditto.

[fs, 2016-05-21 16:05:04]

lgtm

[Srirama, 2016-05-23 05:17:05]

Description was changed from

==========
Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h
macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515
Cr-Commit-Position: refs/heads/master@{#395078}

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

to

==========
Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h
macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

[Srirama, 2016-05-23 05:44:34]

https://codereview.chromium.org/2003433005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/TextTrack.cpp (right):

https://codereview.chromium.org/2003433005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/TextTrack.cpp:280: DCHECK(wasRemoved);
On 2016/05/21 16:04:52, fs wrote:
> Let's try:
> 
> bool wasRemoved = ...;
> DCHECK(wasRemoved);
> 
> this time.
> 
> At least if my reading of
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/logging.h&q=D...
> 
> is correct, that ought to work out.

Done.

https://codereview.chromium.org/2003433005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp (right):

https://codereview.chromium.org/2003433005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp:784: DCHECK(check);
On 2016/05/21 16:04:52, fs wrote:
> Ditto.

Done.

[Srirama, 2016-05-23 05:44:44]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-05-23 05:44:44]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2003433005/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-23 05:44:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003433005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003433005/40001

[commit-bot: I haz the power, 2016-05-23 07:35:26]

Description was changed from

==========
Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h
macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

to

==========
Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h
macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

[commit-bot: I haz the power, 2016-05-23 07:35:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-23 07:36:35]

Description was changed from

==========
Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h
macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)
==========

to

==========
Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h
macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

patch from issue 2003543002 at patchset 40001
(http://crrev.com/2003543002#ps40001)

Committed: https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e
Cr-Commit-Position: refs/heads/master@{#395291}
==========

[commit-bot: I haz the power, 2016-05-23 07:36:36]

Patchset 3 (id:??) landed as
https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e
Cr-Commit-Position: refs/heads/master@{#395291}