third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp - Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp ('k') | third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

index 24b1f03f6191dbaf0945164a49b8c88cd5567c31..858cd8acab1d101f619c1f1f9b334e2af16a7f1a 100644

--- a/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

@@ -91,13 +91,13 @@ VTTParser::VTTParser(VTTParserClient* client, Document& document)

void VTTParser::getNewCues(HeapVector<Member<TextTrackCue>>& outputCues)

{

- ASSERT(outputCues.isEmpty());

+ DCHECK(outputCues.isEmpty());

outputCues.swap(m_cueList);

}

void VTTParser::getNewRegions(HeapVector<Member<VTTRegion>>& outputRegions)

{

- ASSERT(outputRegions.isEmpty());

+ DCHECK(outputRegions.isEmpty());

outputRegions.swap(m_regionList);

}

@@ -193,7 +193,7 @@ void VTTParser::parse()

void VTTParser::flushPendingCue()

{

- ASSERT(m_lineReader.isAtEndOfStream());

+ DCHECK(m_lineReader.isAtEndOfStream());

// If we're in the CueText state when we run out of data, we emit the pending cue.

if (m_state == CueText)

createNewCue();