third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp - Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp

Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/TextTrack.cpp ('k') | third_party/WebKit/Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp

diff --git a/third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp b/third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp

index 80167606352cb9516ab277da7cae5f34e318884f..751052185dcf00a395cf1b2a646a7caa7094637b 100644

--- a/third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp

+++ b/third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp

@@ -115,7 +115,7 @@ void TextTrackContainer::updateDisplay(HTMLMediaElement& mediaElement, ExposingC

for (size_t i = 0; i < activeCues.size(); ++i) {

TextTrackCue* cue = activeCues[i].data();

- ASSERT(cue->isActive());

+ DCHECK(cue->isActive());

if (!cue->track() || !cue->track()->isRendered() || !cue->isActive())

continue;