third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h - Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h

Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/VideoTrackList.cpp ('k') | third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h

diff --git a/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h b/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h

index c592837525ed4b89713b3a84c130e9ee91160c8e..11b9642492fbbb9450efa7017d1511c8c8a20ede 100644

--- a/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h

+++ b/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h

@@ -55,7 +55,7 @@ public:

// Append data to the internal buffer.

void append(const String& data)

{

- ASSERT(!m_endOfStream);

+ DCHECK(!m_endOfStream);

m_buffer.append(SegmentedString(data));

}

@@ -75,7 +75,7 @@ private:

// Consume the next character the buffer if it is the character |c|.

void scanCharacter(UChar c)

{

- ASSERT(!m_buffer.isEmpty());

+ DCHECK(!m_buffer.isEmpty());

if (m_buffer.currentChar() == c)

m_buffer.advance();

}