Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp

Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp
index d04026329a7653633eae19568c4cda544dafb476..df74cf260bbe753976d683a3bb85574847129d1a 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp
@@ -40,7 +40,7 @@ namespace blink {
#define WEBVTT_ADVANCE_TO(stateName) \
do { \
state = stateName; \
- ASSERT(!m_input.isEmpty()); \
+ DCHECK(!m_input.isEmpty()); \
m_inputStreamPreprocessor.advance(m_input); \
cc = m_inputStreamPreprocessor.nextInputCharacter(); \
goto stateName; \
@@ -76,7 +76,7 @@ VTTTokenizer::VTTTokenizer(const String& input)
, m_inputStreamPreprocessor(this)
{
// Append a EOF marker and close the input "stream".
- ASSERT(!m_input.isClosed());
+ DCHECK(!m_input.isClosed());
m_input.append(SegmentedString(String(&kEndOfFileMarker, 1)));
m_input.close();
}
@@ -174,10 +174,10 @@ bool VTTTokenizer::nextToken(VTTToken& token)
WEBVTT_BEGIN_STATE(TagState) {
if (isTokenizerWhitespace(cc)) {
- ASSERT(result.isEmpty());
+ DCHECK(result.isEmpty());
WEBVTT_ADVANCE_TO(StartTagAnnotationState);
} else if (cc == '.') {
- ASSERT(result.isEmpty());
+ DCHECK(result.isEmpty());
WEBVTT_ADVANCE_TO(StartTagClassState);
} else if (cc == '/') {
WEBVTT_ADVANCE_TO(EndTagState);
@@ -185,7 +185,7 @@ bool VTTTokenizer::nextToken(VTTToken& token)
result.append(cc);
WEBVTT_ADVANCE_TO(TimestampTagState);
} else if (cc == '>' || cc == kEndOfFileMarker) {
- ASSERT(result.isEmpty());
+ DCHECK(result.isEmpty());
return advanceAndEmitToken(m_input, token, VTTToken::StartTag(result.toString()));
} else {
result.append(cc);
@@ -255,7 +255,7 @@ bool VTTTokenizer::nextToken(VTTToken& token)
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}
« no previous file with comments | « third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698