Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp

Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp
diff --git a/third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp b/third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp
index fd3eaef9e2112741ca629b94ab126838e7ae5bad..5ee268e923a880e4161985b7e8866177a2a751bd 100644
--- a/third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp
+++ b/third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp
@@ -67,8 +67,8 @@ void TextTrackCueList::collectActiveCues(TextTrackCueList& activeCues) const
bool TextTrackCueList::add(TextTrackCue* cue)
{
- ASSERT(cue->startTime() >= 0);
- ASSERT(cue->endTime() >= 0);
+ DCHECK_GE(cue->startTime(), 0);
+ DCHECK_GE(cue->endTime(), 0);
// Maintain text track cue order:
// https://html.spec.whatwg.org/#text-track-cue-order
@@ -95,7 +95,7 @@ size_t TextTrackCueList::findInsertionIndex(const TextTrackCue* cueToInsert) con
{
auto it = std::upper_bound(m_list.begin(), m_list.end(), cueToInsert, cueIsBefore);
size_t index = safeCast<size_t>(it - m_list.begin());
- ASSERT_WITH_SECURITY_IMPLICATION(index <= m_list.size());
+ SECURITY_DCHECK(index <= m_list.size());
return index;
}

Powered by Google App Engine
This is Rietveld 408576698