Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp

Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
index 9bd6ee829579e93eb09f172a8fd137f95ddcface..40562097aba09e9ac8de07f4bc523e8af170a8d7 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
@@ -333,7 +333,7 @@ HTMLDivElement* VTTRegion::getDisplayTree(Document& document)
void VTTRegion::willRemoveVTTCueBox(VTTCueBox* box)
{
DVLOG(VTT_LOG_LEVEL) << "willRemoveVTTCueBox";
- ASSERT(m_cueContainer->contains(box));
+ DCHECK(m_cueContainer->contains(box));
double boxHeight = box->getBoundingClientRect()->bottom() - box->getBoundingClientRect()->top();
@@ -345,7 +345,7 @@ void VTTRegion::willRemoveVTTCueBox(VTTCueBox* box)
void VTTRegion::appendVTTCueBox(VTTCueBox* displayBox)
{
- ASSERT(m_cueContainer);
+ DCHECK(m_cueContainer);
if (m_cueContainer->contains(displayBox))
return;
@@ -357,7 +357,7 @@ void VTTRegion::appendVTTCueBox(VTTCueBox* displayBox)
void VTTRegion::displayLastVTTCueBox()
{
DVLOG(VTT_LOG_LEVEL) << "displayLastVTTCueBox";
- ASSERT(m_cueContainer);
+ DCHECK(m_cueContainer);
// FIXME: This should not be causing recalc styles in a loop to set the "top" css
// property to move elements. We should just scroll the text track cues on the
@@ -392,7 +392,7 @@ void VTTRegion::displayLastVTTCueBox()
void VTTRegion::prepareRegionDisplayTree()
{
- ASSERT(m_regionDisplayTree);
+ DCHECK(m_regionDisplayTree);
// 7.2 Prepare region CSS boxes

Powered by Google App Engine
This is Rietveld 408576698