third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp - Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp

Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp ('k') | third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp

diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp

index 9096338b93b0c83384870ddeb0c8483da9a046e7..58aa8e508e7acd78b1841cace2b1d66105c8eacf 100644

--- a/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp

+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp

@@ -59,7 +59,7 @@ static const QualifiedName& nodeTypeToTagName(VTTNodeType nodeType)

return vTag;

case VTTNodeTypeNone:

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return cTag; // Make the compiler happy.

}

@@ -110,7 +110,7 @@ HTMLElement* VTTElement::createEquivalentHTMLElement(Document& document)

htmlElement = HTMLElementFactory::createHTMLElement(HTMLNames::rtTag.localName(), document);

break;

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

htmlElement->setAttribute(HTMLNames::classAttr, getAttribute(HTMLNames::classAttr));