Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp

Issue 2003433005: Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/track/CueTimeline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
diff --git a/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp b/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
index 4026fdb757964095844978a582ec141c339e44b0..15a7acff62ee757c721dc4c491b8281f06593345 100644
--- a/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
+++ b/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
@@ -72,7 +72,7 @@ const AtomicString& AutomaticTrackSelection::preferredTrackKind() const
void AutomaticTrackSelection::performAutomaticTextTrackSelection(const TrackGroup& group)
{
- ASSERT(group.tracks.size());
+ DCHECK(group.tracks.size());
// First, find the track in the group that should be enabled (if any).
HeapVector<Member<TextTrack>> currentlyEnabledTracks;
@@ -142,7 +142,7 @@ void AutomaticTrackSelection::performAutomaticTextTrackSelection(const TrackGrou
void AutomaticTrackSelection::enableDefaultMetadataTextTracks(const TrackGroup& group)
{
- ASSERT(group.tracks.size());
+ DCHECK(group.tracks.size());
// https://html.spec.whatwg.org/multipage/embedded-content.html#honor-user-preferences-for-automatic-text-track-selection
@@ -180,7 +180,7 @@ void AutomaticTrackSelection::perform(TextTrackList& textTracks)
} else if (kind == TextTrack::chaptersKeyword()) {
currentGroup = &chapterTracks;
} else {
- ASSERT(kind == TextTrack::metadataKeyword());
+ DCHECK_EQ(kind, TextTrack::metadataKeyword());
currentGroup = &metadataTracks;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/track/CueTimeline.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698