Refactor ChooserBubbleController

Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController
that chooser UI needs on both desktops and from Apps. But since
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some
functionalities from ChooserBubbleController and moved it to
ChooserController, which is added to
//components/chooser_controller

BUG=611917, 577170
Committed: https://crrev.com/bf183dd5c853046173f09abdd3313084d36d13a3
Cr-Commit-Position: refs/heads/master@{#396492}

[juncai, 2016-05-17 16:35:54]

Description was changed from

==========
Refactor ChooserBubbleController

This patch pulled some functionalities from ChooserBubbleController and
moved it to ChooserController, which is added to
//components/chooser_controller

BUG=611917
==========

to

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth and USB from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/chooser_controller

BUG=611917, 577170
==========

[juncai, 2016-05-17 16:37:00]

juncai@chromium.org changed reviewers:
+ reillyg@chromium.org

[juncai, 2016-05-17 16:37:01]

Please take a look.

[juncai, 2016-05-17 16:37:53]

Description was changed from

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth and USB from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/chooser_controller

BUG=611917, 577170
==========

to

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/chooser_controller

BUG=611917, 577170
==========

[Reilly Grant (use Gerrit), 2016-05-17 17:19:00]

lgtm with nits

In your next patch can you expand the README with a diagram of the classes that
will be involved in the final implementation of the choosers for USB and
Bluetooth? http://asciiflow.com/ will be helpful.

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
File components/chooser_controller/chooser_controller.cc (right):

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
components/chooser_controller/chooser_controller.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
File components/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
components/chooser_controller/chooser_controller.h:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
components/chooser_controller/chooser_controller.h:62: // chooser bubble so that
users can grant permission.
chooser bubble -> chooser

[juncai, 2016-05-17 20:09:24]

juncai@chromium.org changed reviewers:
+ caitkp@chromium.org, sky@chromium.org

[juncai, 2016-05-17 20:09:25]

caitkp@chromium.org: Please review changes in 
//components

sky@chromium.org: Please review changes in 
//chrome/browser/ui

Updated README for ChooserController.

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
File components/chooser_controller/chooser_controller.cc (right):

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
components/chooser_controller/chooser_controller.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/05/17 17:19:00, Reilly Grant wrote:
> 2016

Done.

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
File components/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
components/chooser_controller/chooser_controller.h:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/05/17 17:19:00, Reilly Grant wrote:
> 2016

Done.

https://codereview.chromium.org/1984923002/diff/40001/components/chooser_cont...
components/chooser_controller/chooser_controller.h:62: // chooser bubble so that
users can grant permission.
On 2016/05/17 17:19:00, Reilly Grant wrote:
> chooser bubble -> chooser

Done.

[sky, 2016-05-17 21:10:45]

LGTM

https://codereview.chromium.org/1984923002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h (right):

https://codereview.chromium.org/1984923002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h:24:
ChooserBubbleUiView(Browser* browser, ChooserController* controller);
Document ownership.

https://codereview.chromium.org/1984923002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h:40: };
nit: DISALLOW_...

[Cait (Slow), 2016-05-18 19:51:01]

caitkp@chromium.org changed reviewers:
+ blundell@chromium.org, jochen@chromium.org, sdefresne@chromium.org

[Cait (Slow), 2016-05-18 19:51:01]

[+ other components/ OWNERS for their thoughts]

I'm not sure how I feel about creating an entire component for a single
interface. 

Are there plans to add anything else to this component?

https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
File components/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
components/chooser_controller/chooser_controller.h:27: // call back into it is
not allowed.
grammar nit: "...calls back into it are not allowed."

[juncai, 2016-05-18 20:25:35]

On 2016/05/18 19:51:01, Cait - OOO May 20-May 30 wrote:
> [+ other components/ OWNERS for their thoughts]
> 
> I'm not sure how I feel about creating an entire component for a single
> interface. 
> 
> Are there plans to add anything else to this component?
> 
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> File components/chooser_controller/chooser_controller.h (right):
> 
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> components/chooser_controller/chooser_controller.h:27: // call back into it is
> not allowed.
> grammar nit: "...calls back into it are not allowed."

I see. Since it is UI related, how about moving it to:
//components/ui/ ?

[sdefresne, 2016-05-19 09:32:13]

On 2016/05/18 20:25:35, juncai wrote:
> On 2016/05/18 19:51:01, Cait - OOO May 20-May 30 wrote:
> > [+ other components/ OWNERS for their thoughts]
> > 
> > I'm not sure how I feel about creating an entire component for a single
> > interface. 
> > 
> > Are there plans to add anything else to this component?
> > 
> >
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> > File components/chooser_controller/chooser_controller.h (right):
> > 
> >
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> > components/chooser_controller/chooser_controller.h:27: // call back into it
is
> > not allowed.
> > grammar nit: "...calls back into it are not allowed."
> 
> I see. Since it is UI related, how about moving it to:
> //components/ui/ ?

Since clients are //extensions and //chrome/browser/ui, can't this be moved to
//extensions?

[blundell, 2016-05-19 10:37:15]

On 2016/05/19 09:32:13, sdefresne wrote:
> On 2016/05/18 20:25:35, juncai wrote:
> > On 2016/05/18 19:51:01, Cait - OOO May 20-May 30 wrote:
> > > [+ other components/ OWNERS for their thoughts]
> > > 
> > > I'm not sure how I feel about creating an entire component for a single
> > > interface. 
> > > 
> > > Are there plans to add anything else to this component?
> > > 
> > >
> >
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> > > File components/chooser_controller/chooser_controller.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> > > components/chooser_controller/chooser_controller.h:27: // call back into
it
> is
> > > not allowed.
> > > grammar nit: "...calls back into it are not allowed."
> > 
> > I see. Since it is UI related, how about moving it to:
> > //components/ui/ ?
> 
> Since clients are //extensions and //chrome/browser/ui, can't this be moved to
> //extensions?

Creating a component for a single interface is fine (there are several existing
components of that nature). That said, I agree with Sylvain.

[sdefresne, 2016-05-19 13:20:10]

On 2016/05/19 10:37:15, blundell wrote:
> On 2016/05/19 09:32:13, sdefresne wrote:
> > On 2016/05/18 20:25:35, juncai wrote:
> > > On 2016/05/18 19:51:01, Cait - OOO May 20-May 30 wrote:
> > > > [+ other components/ OWNERS for their thoughts]
> > > > 
> > > > I'm not sure how I feel about creating an entire component for a single
> > > > interface. 
> > > > 
> > > > Are there plans to add anything else to this component?
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> > > > File components/chooser_controller/chooser_controller.h (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> > > > components/chooser_controller/chooser_controller.h:27: // call back into
> it
> > is
> > > > not allowed.
> > > > grammar nit: "...calls back into it are not allowed."
> > > 
> > > I see. Since it is UI related, how about moving it to:
> > > //components/ui/ ?
> > 
> > Since clients are //extensions and //chrome/browser/ui, can't this be moved
to
> > //extensions?
> 
> Creating a component for a single interface is fine (there are several
existing
> components of that nature). That said, I agree with Sylvain.

Yes, forgot to say that it is fine to have a component for a single interface if
they have multiple clients (ios vs chrome, ...). We already have some really
thin components for exactly that reason. My suggestion was because I'm not sure
we have to separates clients here (can //extensions be used by code outside of
//chrome?).

[scheib, 2016-05-19 17:13:21]

On 2016/05/19 13:20:10, sdefresne wrote:
> On 2016/05/19 10:37:15, blundell wrote:
> > On 2016/05/19 09:32:13, sdefresne wrote:
> > > On 2016/05/18 20:25:35, juncai wrote:
> > > > On 2016/05/18 19:51:01, Cait - OOO May 20-May 30 wrote:
> > > > > [+ other components/ OWNERS for their thoughts]
> > > > > 
> > > > > I'm not sure how I feel about creating an entire component for a
single
> > > > > interface. 
> > > > > 
> > > > > Are there plans to add anything else to this component?
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> > > > > File components/chooser_controller/chooser_controller.h (right):
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
> > > > > components/chooser_controller/chooser_controller.h:27: // call back
into
> > it
> > > is
> > > > > not allowed.
> > > > > grammar nit: "...calls back into it are not allowed."
> > > > 
> > > > I see. Since it is UI related, how about moving it to:
> > > > //components/ui/ ?
> > > 
> > > Since clients are //extensions and //chrome/browser/ui, can't this be
moved
> to
> > > //extensions?
> > 
> > Creating a component for a single interface is fine (there are several
> existing
> > components of that nature). That said, I agree with Sylvain.
> 
> Yes, forgot to say that it is fine to have a component for a single interface
if
> they have multiple clients (ios vs chrome, ...). We already have some really
> thin components for exactly that reason. My suggestion was because I'm not
sure
> we have to separates clients here (can //extensions be used by code outside of
> //chrome?).

//extensions feels rather awkward for an interface that is used by extensions
but is not an extensions concept. If there are non extension clients of code
that would continue to exist if extensions are removed from the code base then
that code should not be in //extensions.

[juncai, 2016-05-19 23:29:15]

https://codereview.chromium.org/1984923002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h (right):

https://codereview.chromium.org/1984923002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h:24:
ChooserBubbleUiView(Browser* browser, ChooserController* controller);
On 2016/05/17 21:10:45, sky wrote:
> Document ownership.

Done.

https://codereview.chromium.org/1984923002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h:40: };
On 2016/05/17 21:10:45, sky wrote:
> nit: DISALLOW_...

Done.

https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
File components/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/1984923002/diff/80001/components/chooser_cont...
components/chooser_controller/chooser_controller.h:27: // call back into it is
not allowed.
On 2016/05/18 19:51:01, Cait - OOO May 20-May 30 wrote:
> grammar nit: "...calls back into it are not allowed."

Done.

[blundell, 2016-05-20 07:26:39]

//components looks fine to me, but I'm hesitant to give an LG given that Cait
hasn't weighed back in on her concern.

Looking at the interface, I agree that stashing it in //extensions would be a
suboptimal fit.

https://codereview.chromium.org/1984923002/diff/110001/components/ui/chooser_...
File components/ui/chooser_controller/DEPS (right):

https://codereview.chromium.org/1984923002/diff/110001/components/ui/chooser_...
components/ui/chooser_controller/DEPS:2: "+base",
nit: not necessary

https://codereview.chromium.org/1984923002/diff/110001/components/ui/chooser_...
File components/ui/chooser_controller/README (right):

https://codereview.chromium.org/1984923002/diff/110001/components/ui/chooser_...
components/ui/chooser_controller/README:4: Here is the diagram of classes which
use ChooserController.
Are these classes going to end up in this component? If not, it seems like a
layering violation to reference them in this README.

https://codereview.chromium.org/1984923002/diff/110001/components/ui_chooser_...
File components/ui_chooser_controller.gypi (left):

https://codereview.chromium.org/1984923002/diff/110001/components/ui_chooser_...
components/ui_chooser_controller.gypi:11: 'dependencies': [
you need to add deps to match the GN file.

[juncai, 2016-05-20 20:36:11]

https://codereview.chromium.org/1984923002/diff/110001/components/ui/chooser_...
File components/ui/chooser_controller/DEPS (right):

https://codereview.chromium.org/1984923002/diff/110001/components/ui/chooser_...
components/ui/chooser_controller/DEPS:2: "+base",
On 2016/05/20 07:26:39, blundell wrote:
> nit: not necessary

Done.

https://codereview.chromium.org/1984923002/diff/110001/components/ui/chooser_...
File components/ui/chooser_controller/README (right):

https://codereview.chromium.org/1984923002/diff/110001/components/ui/chooser_...
components/ui/chooser_controller/README:4: Here is the diagram of classes which
use ChooserController.
On 2016/05/20 07:26:39, blundell wrote:
> Are these classes going to end up in this component? If not, it seems like a
> layering violation to reference them in this README.

These classes are not in this component. Removed from README.

Done.

https://codereview.chromium.org/1984923002/diff/110001/components/ui_chooser_...
File components/ui_chooser_controller.gypi (left):

https://codereview.chromium.org/1984923002/diff/110001/components/ui_chooser_...
components/ui_chooser_controller.gypi:11: 'dependencies': [
On 2016/05/20 07:26:39, blundell wrote:
> you need to add deps to match the GN file.

Done.

[Cait (Slow), 2016-05-24 20:58:32]

(Apologies for the slow reply -- I'm traveling this week. )

components/ lgtm as does creating a component for the interface. (I agree that
//extensions is not the right place for it).

[juncai, 2016-05-26 00:18:40]

I did a refactoring again. Can you take a look again? Thanks!

[juncai, 2016-05-26 00:25:32]

Description was changed from

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/chooser_controller

BUG=611917, 577170
==========

to

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/ui/chooser_controller

BUG=611917, 577170
==========

[Reilly Grant (use Gerrit), 2016-05-26 00:56:53]

lgtm

https://codereview.chromium.org/1984923002/diff/190001/chrome/browser/ui/blue...
File chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.h (right):

https://codereview.chromium.org/1984923002/diff/190001/chrome/browser/ui/blue...
chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.h:30:
BluetoothChooserController* bluetooth_chooser_controller_;  // Weak.
Please be more specific in this comment. Which object owns this pointer?

[blundell, 2016-05-26 07:11:54]

Please don't land this without addressing the below issue:

You moved the component into //components/ui. I don't like the existence of
//components/ui and would like to eliminate it (I just noticed it for the first
time the other day). There is no pattern in //components of organizing
individual components by logical module (e.g., there's no //components/net,
//components/sync, etc. even though there are multiple net- and sync-related
components). If we were to decide to organize //components by module that would
be a bigger decision that should be made explicitly with commitment to
reorganize all of //components that way. Please move the component back to being
top-level under //components.

[juncai, 2016-05-26 18:13:27]

On 2016/05/26 07:11:54, blundell wrote:
> Please don't land this without addressing the below issue:
> 
> You moved the component into //components/ui. I don't like the existence of
> //components/ui and would like to eliminate it (I just noticed it for the
first
> time the other day). There is no pattern in //components of organizing
> individual components by logical module (e.g., there's no //components/net,
> //components/sync, etc. even though there are multiple net- and sync-related
> components). If we were to decide to organize //components by module that
would
> be a bigger decision that should be made explicitly with commitment to
> reorganize all of //components that way. Please move the component back to
being
> top-level under //components.

Thanks for the comments. I have moved chooser_controller back to the top-level
under //components.

[juncai, 2016-05-26 18:13:39]

https://codereview.chromium.org/1984923002/diff/190001/chrome/browser/ui/blue...
File chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.h (right):

https://codereview.chromium.org/1984923002/diff/190001/chrome/browser/ui/blue...
chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.h:30:
BluetoothChooserController* bluetooth_chooser_controller_;  // Weak.
On 2016/05/26 00:56:53, Reilly Grant wrote:
> Please be more specific in this comment. Which object owns this pointer?

Done.

[blundell, 2016-05-27 08:05:58]

lgtm, thanks!

[juncai, 2016-05-27 11:42:35]

Description was changed from

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/ui/chooser_controller

BUG=611917, 577170
==========

to

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/chooser_controller

BUG=611917, 577170
==========

[juncai, 2016-05-27 15:47:20]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-05-27 15:47:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
caitkp@chromium.org, reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/1984923002/#ps210001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-27 15:47:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984923002/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984923002/210001

[commit-bot: I haz the power, 2016-05-27 15:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 15:55:04]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[juncai, 2016-05-27 16:26:27]

juncai@chromium.org changed reviewers:
+ avi@chromium.org

[juncai, 2016-05-27 16:26:28]

avi@chromium.org:
Please review:
//components/chooser_controller/DEPS

since presubmit failed because of:
Missing LGTM from OWNERS of dependencies added to DEPS:
    '+content/public/browser',

Thanks a lot!

[Avi (use Gerrit), 2016-05-27 16:35:46]

On 2016/05/27 16:26:28, juncai wrote:
> mailto:avi@chromium.org:
> Please review:
> //components/chooser_controller/DEPS
> 
> since presubmit failed because of:
> Missing LGTM from OWNERS of dependencies added to DEPS:
>     '+content/public/browser',
> 
> Thanks a lot!

This dependency is OK. LGTM.

[juncai, 2016-05-27 16:52:43]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-05-27 16:53:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984923002/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984923002/210001

[commit-bot: I haz the power, 2016-05-27 16:57:37]

Description was changed from

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/chooser_controller

BUG=611917, 577170
==========

to

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/chooser_controller

BUG=611917, 577170
==========

[commit-bot: I haz the power, 2016-05-27 16:57:38]

Committed patchset #12 (id:210001)

[commit-bot: I haz the power, 2016-05-27 17:00:20]

Description was changed from

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from 
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController 
that chooser UI needs on both desktops and from Apps. But since 
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some 
functionalities from ChooserBubbleController and moved it to 
ChooserController, which is added to 
//components/chooser_controller

BUG=611917, 577170
==========

to

==========
Refactor ChooserBubbleController

This is part 1 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.

There are many common functionalities in ChooserBubbleController
that chooser UI needs on both desktops and from Apps. But since
now it is at:
//chrome/browser/ui/website_settings/chooser_bubble_controller.h
code from //extensions can not use it. This patch pulled some
functionalities from ChooserBubbleController and moved it to
ChooserController, which is added to
//components/chooser_controller

BUG=611917, 577170

Committed: https://crrev.com/bf183dd5c853046173f09abdd3313084d36d13a3
Cr-Commit-Position: refs/heads/master@{#396492}
==========

[commit-bot: I haz the power, 2016-05-27 17:00:22]

Patchset 12 (id:??) landed as
https://crrev.com/bf183dd5c853046173f09abdd3313084d36d13a3
Cr-Commit-Position: refs/heads/master@{#396492}