Refactor ChooserBubbleUiController on Mac

Refactor ChooserBubbleUiController on Mac

This is part 2 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.

Since the chooser content view is the same for WebBluetooth on desktop
and Chrome Apps, it is better to pull it out of ChooserBubbleUiController
and have a class ChooserContentView that can be reused.

BUG=612942, 577170
Committed: https://crrev.com/d025df067297d50a01861bf680bc67e8f4dab15d
Cr-Commit-Position: refs/heads/master@{#396494}

[juncai, 2016-05-20 21:45:48]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org, thestig@chromium.org

[juncai, 2016-05-20 21:45:49]

thestig@chromium.org: Please review changes in 
//chrome/chrome_browser_ui.gypi

rsesek@chromium.org: Please review changes in 
//chrome/browser/ui/cocoa

[Robert Sesek, 2016-05-23 16:46:34]

https://codereview.chromium.org/1995793002/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/chooser_content_view.h (right):

https://codereview.chromium.org/1995793002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/chooser_content_view.h:27: -
(id)initWithChooserTitle:(NSString*)chooserTitle;
id -> instancetype

https://codereview.chromium.org/1995793002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/chooser_content_view.h:51: - (NSTableView*)getTableView;
Mac getters do not have the word "get" in the name, so this should just be
tableView. Etc.

[juncai, 2016-05-23 17:48:01]

https://codereview.chromium.org/1995793002/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/chooser_content_view.h (right):

https://codereview.chromium.org/1995793002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/chooser_content_view.h:27: -
(id)initWithChooserTitle:(NSString*)chooserTitle;
On 2016/05/23 16:46:34, Robert Sesek wrote:
> id -> instancetype

Done.

https://codereview.chromium.org/1995793002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/chooser_content_view.h:51: - (NSTableView*)getTableView;
On 2016/05/23 16:46:34, Robert Sesek wrote:
> Mac getters do not have the word "get" in the name, so this should just be
> tableView. Etc. 

Done.

[Robert Sesek, 2016-05-23 18:51:02]

lgtm

[Lei Zhang, 2016-05-23 18:54:01]

rslgtm

[juncai, 2016-05-27 17:01:52]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-05-27 17:01:53]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1995793002/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-27 17:02:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995793002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995793002/160001

[commit-bot: I haz the power, 2016-05-27 17:06:30]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-05-27 17:07:42]

Description was changed from

==========
Refactor ChooserBubbleUiController on Mac

This is part 2 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.

Since the chooser content view is the same for WebBluetooth on desktop
and Chrome Apps, it is better to pull it out of ChooserBubbleUiController
and have a class ChooserContentView that can be reused.

BUG=612942, 577170
==========

to

==========
Refactor ChooserBubbleUiController on Mac

This is part 2 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.

Since the chooser content view is the same for WebBluetooth on desktop
and Chrome Apps, it is better to pull it out of ChooserBubbleUiController
and have a class ChooserContentView that can be reused.

BUG=612942, 577170

Committed: https://crrev.com/d025df067297d50a01861bf680bc67e8f4dab15d
Cr-Commit-Position: refs/heads/master@{#396494}
==========

[commit-bot: I haz the power, 2016-05-27 17:07:43]

Patchset 9 (id:??) landed as
https://crrev.com/d025df067297d50a01861bf680bc67e8f4dab15d
Cr-Commit-Position: refs/heads/master@{#396494}